summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Convert genaliases to mmshell, optparse, and configuration.configbwarsaw2006-09-2511-113/+87
| | | | | | | | | | | | | | | | bin/withlist: If there's no '@' in the listname, append the DEFAULT_EMAIL_HOST so we always get a fully qualified list name. bin/mmsitepass: plumb through -C/--config switch and be sure to call config.load(). Convert Mailman/MTA/Postfix.py to configuration.config, and update MTA/Manual. In mailman/Cgi/create, we can't convert straight from a string to a bool, because bool('0') is True. We need to go through int first. MailList.InitTempVars(): The logic here looked weird because we could get 'name' = None and that would break. Assume name is never None.
* As Mark discovered, we need to load the configuration in the driver script forbwarsaw2006-09-245-4/+13
| | | | | | | | the web u/i to work. This also fixes the use of Utils.list_names() in the list and admin overviews. This API now returns a set, but the CGIs want to sort them, so we need to turn them back into lists. This change also elaborates an exception so that the list name is reported.
* Convert check_perms to mmshell symlink, configuration object, and optparsebwarsaw2006-09-244-108/+125
| | | | usage.
* Backing out last change. Mark, you are right.tkikuchi2006-09-231-1/+0
|
* I needed this for web ui to work.tkikuchi2006-09-221-0/+1
|
* Removed the "Discard all messages marked Defer" checkbox from themsapiro2006-09-211-2/+2
| | | details=all page.
* Revert a XEmacs weirdness.bwarsaw2006-09-171-2/+2
|
* getting rid of out of date admin directorybwarsaw2006-09-171-2/+2
|
* Several fixes.pheinlein2006-08-312-30/+21
|
* Fix several problems reported by Mark. First, Python 2.3 doesn't havebwarsaw2006-08-294-6/+13
| | | | | | | | | | | | | | | | | | | built-in sets and sadly we still have to support it. Utils.list_names() therefore now uses a sets.Set if it finds the built-in set type missing. main() in list_lists.py also has to list()-ify the set in order to sort it. There's a bootstrapping problem when bin/update tries to re-situate a non-qualified list name to a qualified list name. The problem is that the MailList ctor will call Load() with the nonqual name, which in turn will call CheckVersion() by default. The latter will then turn around and try to call Load() with the fqdn list name, but that list name won't yet exist since it hasn't been situated. The solution (but maybe not the best one) then is to pass the check_version flag to the MailList ctor, which gets passed down to the Load() call. Only situate_list() will call this to avoid the version checking before the list has been situated.
* Arabic message for mailman-2.2 ... it wasn't there because I used cp -r fromtkikuchi2006-08-161-0/+15702
| | | | mailman-2.1 directory and .svn was also copied. :-(
* Revision marking makes these translations fuzzy.tkikuchi2006-08-053-3/+0
|
* Fix bug incluing .svn files.tkikuchi2006-08-051-1/+1
|
* New language: Arabic.tkikuchi2006-08-051-0/+4
|
* Changed the descriptions of the ARCHIVE_TO_MBOX settings to moremsapiro2006-08-011-5/+7
| | | | accurately represent their current meaning.
* Upgrade to email package version 4.0.1. Because email 4.0.1 is onlybwarsaw2006-07-309-40/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | compatible back to Python 2.3, this change should not get back ported to Mailman 2.1. Port to Python 2.5. The non-test suite changes should get back ported to Mailman 2.1 (which I will do next), but don't worry about the test suite ones because MM2.1's test suite is hopeless. Specifically: - In SecurityManager.py, fix the parsecookie() code to work with Python 2.5 generated cookie text. The latter was changed to be more RFC compliant so it does not output training semicolons for each line of cookie text. This broke the splitting rules, so now first split on newlines, then on ';\s*'. This should work across all Python versions. - In Python 2.5, exceptions are new-style, and thus are no longer of ClassType. The instantiation type test in hold_for_approval() was too naive. - Raising strings generates deprecation warnings in Python 2.5. Switch the one weird use of this in Utils.py to use a class exception. Don't call it "quick exit" though because it's probably not. - In the tests, use True/False instead of 1/0 - Use failUnless/failIf instead of assertEqual against True/False. - In the tests, use Message.get_content_type() instead of Message.get_type() since the latter is gone in email 4.0.1. Same with get_content_maintype() and get_main_type().
* SendSubscribeAck() - Removed test of self.send_welcome_message.msapiro2006-07-241-2/+0
| | | The caller may want to override the list setting.
* - Switchboard.py Added missing call to create error logger.msapiro2006-07-221-1/+3
|
* Committed messages mailman.po file for both Dutch and Vietnamese.clytie2006-07-212-3060/+2822
| | | Clytie Siddall <clytie@riverland.net.au>.
* - Mailman/bin/unshunt.pymsapiro2006-07-161-2/+2
| | | tosb.finish() call is the wrong switchboard. Changed to sb.finish().
* Add a framework for easier use of alternative MemberAdaptor implementations.bwarsaw2006-07-169-50/+440
| | | | | | | | | | | | | | | | | | | | | | | | | | Also add an experimental (and currently non-functioning) SQLAlchemy implementation. The MemberAdaptor.py interface has been updated in a couple of ways. First, a "transaction interface" has been added so that Mailman can properly sync with the member adaptor. Newly supported methods are load(), lock(), save(), and unlock() and these correspond to methods in the MailList object. Second, __init__() is officially documented to take a MailList instance and nothing else. Third, some of the existing docstrings were incorrect w.r.t. the OldStyleMemberships implementation (such as rasing BadPasswordError in some cases). Most of these should not be the responsibility of the MemberAdaptor, so the docstrings have been updated. Test cases have been added and a new Defaults.py.in variable called MEMBER_ADAPTOR_CLASS has been added which names the class to use. Of course OldStyleMemberships are named by default. There's also a SQLALCHEMY_ENGINE_URL variable for use with the experimental member adaptor. Fix a bug in Configuration where if the etc/mailman.cfg file wasn't found and the mm_cfg.py file was used as a fallback, it would blow away the original namespace copied from Defaults.py.in. This wasn't a problem until we started adding additional names to that namespace, such as 'add_domain'.
* Added robustness to Switchboards and Runners so that if a runner crashesbwarsaw2006-07-1611-130/+380
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | uncleanly (e.g. segfaults the Python interpreter), messages being processed will not be lost. The vulnerability, ideas, and patches are credited to Richard Barrett and Mark Sapiro. Their original work was modified by Barry for this commit and any bugs are his fault. The basic idea is that instead of unlinking a .pck file in dequeue(), the file is renamed to a .bak file. The Switchboard grows a finish() method which then unlinks the .bak file. That class's constructor also grows a 'restore' argument (defaulting to false), which when true moves all .bak files it finds in its hash space to .pck, thereby restoring a file lost while "in flight". This relies on the fact that even with multiple qrunners, exactly one process will be responsible for one hash space slice, so it's never possible (under normal operation) for a .bak file to be renamed to .pck by some other process. Test cases for both the new Switchboard behavior and the use of that by Runner subclasses has been added. There are two things to watch out for, either of which may require some additional changes. There is some small potential to duplicate messages in various queues, if say 'mailmanctl' were improperly started more than once by a site admin. This usually won't happen unless an admin is overly eager with the mailmanctl -s switch, so we can chalk this one up to operator error. I'm not sure what more we can do about that. There's also a possibility that if we're processing a message that continually causes the Python interpreter to crash, we could end up duplicating messages endlessly. This is especially troublesome for the Outgoing runner which could conceivably cause a mail flood. I consider this the more critical issue to defend against, probably by adding a numbering scheme to the .bak file names and refusing to restore a .bak file more than say 3 times without human intervention.
* - Switchboard.py - Closed very tiny holes at the upper ends of queuemsapiro2006-07-092-4/+15
| | | | | slices that could result in unprocessable queue entries. Improved FIFO processing when two queue entries have the same timestamp.
* Update NEWS and remove an obsolete file.bwarsaw2006-07-082-0/+62
|
* Fix a buglet that can cause bogus archives/private directories to be createdbwarsaw2006-07-081-5/+13
| | | | | | | | when a mailing list is created. The problem is that MailList.Create() will call MailList.InitVars() which in turn calls Archiver.InitVars(). The latter creates private archive directories based on the list's host_name attribute. But Create() couldn't set this to what it knows it should be because MailList.InitVars() always blew it away.
* When an exception occurs during decoration, log it at exception level so we ↵bwarsaw2006-07-082-3/+18
| | | | | | | | | | see the traceback. Make sure that in EmailBase.tearDown() we actually wait for the SinkServer to exit before continuing. We still leave test turds in archives/private, but I haven't yet figured it out.
* Fix some buglets with virtual domain support and repair unit tests broken bybwarsaw2006-07-0820-626/+273
| | | | | | | | | | | | | | | | | | | | | | | this change. More unit tests should be added. misc/sitelist.cfg is removed -- this is an ex-site list. MailList.GetNoReplyEmail() -> MailList.no_reply_address (property) UserNotification._enqueue(), OwnerNotification._enqueue(): when queing the message to the virgin queue, be sure to use the fully qualified (i.e. posting) address for the list. In the MTA modules, be sure to set up the target of the mail commands as the fqdn listname because otherwise we can't find the correct list. This needs some tweaking/testing for Postfix's virtual domain support. MailList.Load() has to grow an optional argument specifying the fqdn listname. The problem is that in some situations, we can't calculate that because we don't know _internal_name, so it has to be passed in. This is mostly the case in the MailList ctor where a Load hasn't happened yet. For backward compatibility though, if it's not passed in, just use mlist.fqdn_listname.
* First crack at real virtual domain support, i.e. mailing lists with the samebwarsaw2006-07-0833-468/+370
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name in more than one domain. - Totally eradicate MAILMAN_SITE_LIST, and in fact the entire need for a site list. The functions that the site list previously performed are either removed or supported in other ways. For example, instead of forwarding owner bounces to the site list, we now have a SITE_OWNER_ADDRESS which should point to a human, and such bounces are sent there instead. There's also a "no reply" email address that should be set up to go to devnull. For any message that never expects a reply, the sender is set to this address. - Remove the Site.py module. It was an experimental approach to trying to support virtual domains, and we're going to do it so much better now that this module is no longer necessary. Site._makedirs() -> Utils.makedir(). - VIRTUAL_HOST_OVERVIEW is completely removed, since now virtual hosts are always enabled. Virtual domains should be added to mailman.cfg by using the new add_domain() function. add_virtualhost() is gone. If no virtual domains are added explicitly, we add the default one that configure guessed (but we never add that if domains are added explicitly). - Utils.get_domain() -> Utils.get_request_domain() - withlist code cleanup and make sure that we load etc/mailman.cfg - A new base exception called MailmanException is added, from which all exceptions defined in Errors.py ultimately derive. MailmanError is retained and derives from MailmanException. - BadDomainSpecificationError is added. - Remove the -V/--virtual-host-overview option from list_lists and add instead -d/--domain and -f/--full. - bin/update probably works but needs more testing. - bin/newlist and bin/rmlist take fqdn list names, but default to the default domain if @whatever isn't given. newlist's -u/--urlhost and -e/--emailhost options are removed. The domain that the list is being added to must already exist. - Minor code cleanup in Message.py - Bump version to 2.2.0a1 - The Configuration object grows a .domain dictionary which maps email hosts to url hosts. The reverse mapping is supported, but not directly; use Configuration.get_email_host() instead. - Mailman/Cgi/create is converted from mm_cfg to config, and some minor code cleanup is performed. Also, convert to __i18n_templates__ = True. - New MailList APIs: + property .fqdn_listname + GetNoReplyEmail() + Create() API changes and refactoring.
* In EmailBase.setUp() move TestBase.setUp() to after the SinkServer is created,bwarsaw2006-07-081-1/+5
| | | | so that failures there won't cause stale _xtest lists to continue to exist.
* Fix test_message.py by finishing the wind-through of the configuration objectbwarsaw2006-07-0825-291/+311
| | | | | | | | | | | | | | | | and fixing the invocation and shutdown of mailmanctl. While the tests in this module work individually, they do not yet work as a group. -C added to testall.py, and mailmanctl now passes that flag on to qrunner. UserNotification sets reduced_list_header in the msgdata, but the behavior of this flag has changed. It used to suppress List-Help, List-Subscribe, and List-Unsubscribe as well as List-Post and List-Archive. However, List-Help, List-Subscribe and List-Unsubscribe should definitely be included in UserNotifications, and List-Post has a different variable controlling it now. Therefore, always add List-Help, List-Subscribe, and List-Unsubscribe. Some style updates to Message.py
* Massive conversion process so that Mailman can be run from a user specifiedbwarsaw2006-07-0840-1943/+2029
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | configuration file. While the full conversion is not yet complete, everything that seems to be required to run mailmanctl, qrunner, rmlist, and newlist have been updated. Basically, modules should no longer import mm_cfg, but instead they should import Mailman.configuration.config. The latter is an object that's guaranteed to exist, but not guaranteed to be initialized until some top-level script calls config.load(). The latter should be called with the argument to -C/--config which is a new convention the above scripts have been given. In most cases, where mm_cfg.<variable> is used config.<variable> can be used, but the exceptions are where the default value must be available before config.load() is called. Sometimes you can import Mailman.Default and get the variable from there, but other times the code has to be changed to work around this limitation. Take each on a case-by-case basis. Note that the various directories calculated from VAR_PREFIX, EXEC_PREFIX, and PREFIX are now calculated in config.py, not in Defaults.py. This way a configuration file can override the base directories and everything should work correctly. Other changes here include: - mailmanctl, qrunner, and update are switched to optparse and $-strings, and changed to the mmshell architecture - An etc directory has been added to /usr/local/mailman and a mailman.cfg.sample file is installed there. Sites should now edit an etc/mailman.cfg file to do their configurations, although the mm_cfg file is still honored. The formats of the two files are identical. - list_lists is given the -C/--config option - Some coding style fixes in bin/update, but not extensive - Get rid of nested scope hacks in qrunner.py - A start on getting EmailBase tests working (specifically test_message), although not yet complete.
* - Utils.py Fixed a security hole which allowed a crafted URI to injectmsapiro2006-07-078-7/+113
| | | | | | | | | | | | | | | | | | | | bogus apparent messages into the error log, possibly inducing an admin to visit a phishing site. - options.py Topics.py Tagger.py MailList.py Utils.py Version.py versions.py The processing of Topics regular expressions has changed. Previously the Topics regexp was compiled in verbose mode but not documented as such which caused some confusion. Also, the documentation indicated that topic keywords could be entered one per line, but these entries were not properly. Topics regexps are now compiled in non-verbose mode and multi- line entries are 'ored'. Existing Topics regexps will be converted when the list is updated so they will continue to work.
* Several fixes and updates.pheinlein2006-07-051-381/+324
|
* - Decorate.py Fixed bug 1507248 by ignoring header/footer charactersmsapiro2006-06-231-2/+2
| | | | outside the character set of the list's language.
* Updated a few bouncers to recognize more bounces.msapiro2006-06-1117-2/+1628
| | | Added more test cases.
* Added '(by thread)' to the previous and next message links to emphasize thatmsapiro2006-06-111-2/+2
| | | | even if you got to the message from a subject, date or author index, previous and next are still by thread.
* Added a call to loginit.initialize() so invoked modules can do their logging.msapiro2006-06-111-2/+8
|
* - newlist.pymsapiro2006-06-082-2/+10
| | | | | | | | Added 'automate' option to be 'quiet' but still send admin notice. - admindbdetails.html Changed 'Approve' wording to 'Approve/Accept' for consistency with button labels.
* - show_mm_cfg.pymsapiro2006-06-042-114/+102
| | | | | | | | Added pretty printing. - dumpdb Fixed to once again dump marshals. Converted to use optparse. Did not convert to mmshell framework because it's not compatible with 'interactive' usage.
* Added a new show_mm_cfg command line script to show the actual valuesmsapiro2006-06-022-1/+79
| | | of variables imported from mm_cfg.
* Replaced call to no longer existent Message.OutgoingMessage() with call tomsapiro2006-05-301-1/+2
| | | | email.message_from_string(text, Message.Message) (Sourceforge is migrating from 1.x - scary)
* Added removal of Authentication-Results: header as it too is no longer valid.msapiro2006-05-231-0/+1
|
* Fixed paths in file opening for new structure and test bounces location.msapiro2006-05-191-2/+5
|
* Removed bounces directory from SUBDIRS. It's moved to Mailman/testing.msapiro2006-05-191-1/+1
|
* Reorganize the unit test infrastructure, so that tests live inside thebwarsaw2006-05-1896-215/+389
| | | | | | | | | | | | | | | | | Mailman top level package. Rewrote the test runner and stuck it in bin (as an mmshell symlink). bin/testall now autodetects tests and allows running a subset of tests via regular expression filtering. I also fixed all the tests so they all pass now, with the exception of test_message.py tests. These still doesn't work because of coordination issues between its smtpd-based reader and SMTPDirect, but... I have a plan (mwah, ha, ha! :) I also fixed a code update bug in Decorate.py
* - Cgi/options.py - fixed to not present the "empty" topic to user.msapiro2006-05-172-0/+6
| | | | - Handlers/CalcRecips.py - Changed to not process topics if topics are disabled for the list.
* Set package name and version number in AC_INIT macro in configure.in. Also,bwarsaw2006-05-1520-95/+100
| | | | | | | | | | | | | | | | | | | require Python to be at least 2.3.0 Convert all scripts/* scripts (except driver) to use the symlink-to-bin/mmshell trick. For now (since we're debugging more often than releasing), set STEALTH_MODE to False in scripts/driver. We need to remember to turn this back to True when we start getting closer to releases! In the various scripts, er, Mailman/bin scripts, convert them to $-strings for i18n substitution, and clean up imports. Also, get rid of the crufty Emacs -*- line, which is no longer needed now that the files end in .py. Get rid of lots of unnecessary svn:executable properties. Remove an unnecessary import from Mailman/bin/disabled.py
* - Added additional bounce recognition for Qmail and SimpleMatch.pymsapiro2006-05-145-1/+165
| | | | - Added test cases for above.
* Move all cron scripts to the new Mailman.bin package layout and complete thebwarsaw2006-05-1313-844/+438
| | | | | conversion to optparse style option parsing. Remove mailpasswds as password reminders will go away for MM2.2.
* - fixed misspelling of propagate in loginit.initialize call in cron/disabled.msapiro2006-05-098-23/+61
| | | | | (should the cron scripts propagate log messages to stderr?) - updated scripts/* scripts to use new logging rather than stderr writes.