summaryrefslogtreecommitdiff
path: root/Mailman/Cgi/admin.py
diff options
context:
space:
mode:
authorklm1998-09-30 17:03:44 +0000
committerklm1998-09-30 17:03:44 +0000
commit4644b4ba0afaca2436cd0221765635b113fceab5 (patch)
treee3bf157bec228a4f1327a2dd55a259c3285f28a7 /Mailman/Cgi/admin.py
parent3f806409ad7c379993f87a69f018d687664c436f (diff)
downloadmailman-4644b4ba0afaca2436cd0221765635b113fceab5.tar.gz
mailman-4644b4ba0afaca2436cd0221765635b113fceab5.tar.zst
mailman-4644b4ba0afaca2436cd0221765635b113fceab5.zip
.SetHeader(): New headers would not show in resulting message unless
optional "crush_duplicates" was set to 0, because the msg.dict would get the new entry, but the msg.headers would not. I've changed the code so that the non-crush_duplicates addition to msg.headers would happen whenever the header is new, regardless of crush_duplicates setting. (Of course, the newness of the header means there are no duplicates to crush...) Incidentally! John, there's a line at the top of this routine whose purpose i don't understand - i think it was there when i got the code, so i'm wondering if you know about it. It's the first line of code in the routine: name = "%s%s" % (name[0], name[1:]) The only thing i can think this would serve is to establish that the length of the name is at least 1 - seems to me it would be more efficient and clear to make the check explicit, if that's the purpose, avoid the assignment, etc. I suspect i'm missing something here - can you shed any light??
Diffstat (limited to 'Mailman/Cgi/admin.py')
0 files changed, 0 insertions, 0 deletions