aboutsummaryrefslogtreecommitdiffhomepage
path: root/sec_certs
diff options
context:
space:
mode:
authorGeogeFI2021-10-26 19:02:56 +0200
committerGeogeFI2021-10-26 19:02:56 +0200
commita8a36f84e9df7dcb4bf024b2ff70fc6db6041823 (patch)
tree7ebb9c498cfab9219f70f7db14394f8e9c51b343 /sec_certs
parent58a97e7c991a4920f3091b97dbae71acc2e4e8cb (diff)
downloadsec-certs-a8a36f84e9df7dcb4bf024b2ff70fc6db6041823.tar.gz
sec-certs-a8a36f84e9df7dcb4bf024b2ff70fc6db6041823.tar.zst
sec-certs-a8a36f84e9df7dcb4bf024b2ff70fc6db6041823.zip
fix: Fixed semantic bugs
Diffstat (limited to 'sec_certs')
-rw-r--r--sec_certs/dataset/common_criteria.py4
-rw-r--r--sec_certs/helpers.py12
2 files changed, 8 insertions, 8 deletions
diff --git a/sec_certs/dataset/common_criteria.py b/sec_certs/dataset/common_criteria.py
index 0ab60ec5..39c6594e 100644
--- a/sec_certs/dataset/common_criteria.py
+++ b/sec_certs/dataset/common_criteria.py
@@ -635,7 +635,7 @@ class CCDataset(Dataset, ComplexSerializableType):
return referenced_by_indirect.get(cert, None)
def _compute_affected_ids(self):
- referenced_by_direct, referenced_by_indirect = build_cert_references(self.certs)
+ referenced_by_direct, referenced_by_indirect = helpers.build_cert_references(self.certs)
for cert in self:
current_cert_id = cert.pdf_data.cert_id
@@ -663,7 +663,7 @@ class CCDataset(Dataset, ComplexSerializableType):
return filter_indirect
def _compute_affecting_ids(self):
- referenced_by_direct, referenced_by_indirect = build_cert_references(self.certs)
+ referenced_by_direct, referenced_by_indirect = helpers.build_cert_references(self.certs)
for cert in self:
current_cert_id = cert.pdf_data.cert_id
diff --git a/sec_certs/helpers.py b/sec_certs/helpers.py
index c558adae..20f919c3 100644
--- a/sec_certs/helpers.py
+++ b/sec_certs/helpers.py
@@ -726,16 +726,16 @@ def compute_heuristics_version(cert_name: str) -> List[str]:
def build_cert_references(certificates):
referenced_by = {}
- for cert in certificates:
- if cert.pdf_data.report_keywords is None:
+ for cert_digest in certificates:
+ if certificates[cert_digest].pdf_data.report_keywords is None:
continue
this_cert_id = None
- if cert.pdf_data.processed_cert_id is not None:
- this_cert_id = cert.pdf_data.processed_cert_id
+ if certificates[cert_digest].pdf_data.processed_cert_id is not None:
+ this_cert_id = certificates[cert_digest].pdf_data.processed_cert_id
# Direct reference
- for cert_id in cert.pdf_data.report_keywords["rules_cert_id"]:
+ for cert_id in certificates[cert_digest].pdf_data.report_keywords["rules_cert_id"]:
if cert_id != this_cert_id and this_cert_id is not None:
if cert_id not in referenced_by:
referenced_by[cert_id] = []
@@ -753,7 +753,7 @@ def build_cert_references(certificates):
while new_change_detected:
new_change_detected = False
certs_id_list = referenced_by.keys()
-
+
for cert_id in certs_id_list:
tmp_referenced_by_indirect_nums = referenced_by_indirect[cert_id].copy()
for referencing in tmp_referenced_by_indirect_nums: