diff options
| author | Adam Janovsky | 2022-12-14 13:42:47 +0100 |
|---|---|---|
| committer | Adam Janovsky | 2022-12-14 13:42:47 +0100 |
| commit | 8af0d58b1fa763aa3fa923b08bacac1c6319fdc1 (patch) | |
| tree | 377ce1be12c4a6214a3351c24a81d15a36bcb02d | |
| parent | 7f5c7ba98c651bbf805546fb97e130b849298d89 (diff) | |
| download | sec-certs-8af0d58b1fa763aa3fa923b08bacac1c6319fdc1.tar.gz sec-certs-8af0d58b1fa763aa3fa923b08bacac1c6319fdc1.tar.zst sec-certs-8af0d58b1fa763aa3fa923b08bacac1c6319fdc1.zip | |
delete draft release action (not used)
| -rw-r--r-- | .github/workflows/draft_release.yml | 19 | ||||
| -rw-r--r-- | CONTRIBUTING.md | 7 |
2 files changed, 2 insertions, 24 deletions
diff --git a/.github/workflows/draft_release.yml b/.github/workflows/draft_release.yml deleted file mode 100644 index 55c6a38a..00000000 --- a/.github/workflows/draft_release.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Create release draft - -on: - push: - tags: - - "*.*.*" - -jobs: - draft-release: - runs-on: ubuntu-latest - if: (github.repository == 'crocs-muni/sec-certs') && (github.ref == 'refs/heads/main') - steps: - - name: Checkout - uses: actions/checkout@v3 - - name: Release - uses: softprops/action-gh-release@v1 - with: - draft: true - generate_release_notes: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 958ba073..dd00667f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,8 +25,6 @@ Requirements are maintained with [pip-tools](https://github.com/jazzband/pip-too ## Releases and version strings -- On each revision pushed onto `main` that has `*.*.*` tag, a draft release is created with prepared changelog (this step can be skipped and the Release created right from the GitHub GUI). -- This draft release is to be published manually by the maintainer. - Version string is not indexed in `git` but can be retreived maintained by `setuptools-scm` from git tags instead. - `setuptools-scm` will automatically, upon editable/real install of a package, infer its version and write it to `sec_certs/_version.py`. This file is not indexed as well. See more at [setuptools-scm GitHub](https://github.com/pypa/setuptools_scm) - On publishing a release, the tool is automatically published to [PyPi](https://pypi.org/project/sec-certs/) and [DockerHub](https://hub.docker.com/repository/docker/seccerts/sec-certs). @@ -35,9 +33,8 @@ Note on single-sourcing the package version: More can be read [here](https://pac ### Currently, the release process is as follows -1. (skip this optionally) Tag a revision with `*.*.*` tag -- this will create a draft release in GitHub. -2. Modify changelog and publish the release (or create it from scratch with new tag). -3. This will automatically update PyPi and DockerHub packages. +1. Create a release from GitHub UI. Include release notes, add proper version tag and publish the release (or create it from scratch with new tag). +2. This will automatically update PyPi and DockerHub packages. ## Quality assurance |
