1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
|
# Copyright (C) 2012-2014 by the Free Software Foundation, Inc.
#
# This file is part of GNU Mailman.
#
# GNU Mailman is free software: you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free
# Software Foundation, either version 3 of the License, or (at your option)
# any later version.
#
# GNU Mailman is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
# more details.
#
# You should have received a copy of the GNU General Public License along with
# GNU Mailman. If not, see <http://www.gnu.org/licenses/>.
"""Test the `approved` handler."""
from __future__ import absolute_import, print_function, unicode_literals
__metaclass__ = type
__all__ = [
'TestApproved',
'TestApprovedNonASCII',
'TestApprovedPseudoHeader',
'TestApprovedPseudoHeaderMIME',
'TestPasswordHashMigration',
]
import os
import unittest
from mailman.app.lifecycle import create_list
from mailman.config import config
from mailman.rules import approved
from mailman.testing.helpers import (
configuration,
specialized_message_from_string as mfs)
from mailman.testing.layers import ConfigLayer
class TestApproved(unittest.TestCase):
"""Test the approved handler."""
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
self._mlist.moderator_password = config.password_context.encrypt(
'super secret')
self._rule = approved.Approved()
self._msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A Message with non-ascii body
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
def test_approved_header(self):
self._msg['Approved'] = 'super secret'
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_approve_header(self):
self._msg['Approve'] = 'super secret'
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_x_approved_header(self):
self._msg['X-Approved'] = 'super secret'
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_x_approve_header(self):
self._msg['X-Approve'] = 'super secret'
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_approved_header_wrong_password(self):
self._msg['Approved'] = 'not the password'
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_approve_header_wrong_password(self):
self._msg['Approve'] = 'not the password'
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_x_approved_header_wrong_password(self):
self._msg['X-Approved'] = 'not the password'
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_x_approve_header_wrong_password(self):
self._msg['X-Approve'] = 'not the password'
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_removes_approved_header(self):
self._msg['Approved'] = 'super secret'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['approved'], None)
def test_removes_approve_header(self):
self._msg['Approve'] = 'super secret'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['approve'], None)
def test_removes_x_approved_header(self):
self._msg['X-Approved'] = 'super secret'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['x-approved'], None)
def test_removes_x_approve_header(self):
self._msg['X-Approve'] = 'super secret'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['x-approve'], None)
def test_removes_approved_header_wrong_password(self):
self._msg['Approved'] = 'not the password'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['approved'], None)
def test_removes_approve_header_wrong_password(self):
self._msg['Approve'] = 'not the password'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['approve'], None)
def test_removes_x_approved_header_wrong_password(self):
self._msg['X-Approved'] = 'not the password'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['x-approved'], None)
def test_removes_x_approve_header_wrong_password(self):
self._msg['X-Approve'] = 'not the password'
self._rule.check(self._mlist, self._msg, {})
self.assertEqual(self._msg['x-approve'], None)
class TestApprovedPseudoHeader(unittest.TestCase):
"""Test the approved handler."""
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
self._mlist.moderator_password = config.password_context.encrypt(
'super secret')
self._rule = approved.Approved()
self._msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A Message with non-ascii body
Message-ID: <ant>
MIME-Version: 1.0
""")
def test_approved_pseudo_header(self):
self._msg.set_payload("""\
Approved: super secret
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_approve_pseudo_header(self):
self._msg.set_payload("""\
Approve: super secret
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_x_approved_pseudo_header(self):
self._msg.set_payload("""\
X-Approved: super secret
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_x_approve_pseudo_header(self):
self._msg.set_payload("""\
X-Approve: super secret
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
def test_approved_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
Approved: not the password
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_approve_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
Approve: not the password
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_x_approved_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
X-Approved: not the password
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_x_approve_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
X-Approve: not the password
""")
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
def test_removes_approved_pseudo_header(self):
self._msg.set_payload("""\
Approved: super secret
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('Approved' in self._msg.get_payload())
def test_removes_approve_pseudo_header(self):
self._msg.set_payload("""\
Approve: super secret
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('Approve' in self._msg.get_payload())
def test_removes_x_approved_pseudo_header(self):
self._msg.set_payload("""\
X-Approved: super secret
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('X-Approved' in self._msg.get_payload())
def test_removes_x_approve_pseudo_header(self):
self._msg.set_payload("""\
X-Approve: super secret
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('X-Approve' in self._msg.get_payload())
def test_removes_approved_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
Approved: not the password
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('Approved' in self._msg.get_payload())
def test_removes_approve_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
Approve: not the password
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('Approve' in self._msg.get_payload())
def test_removes_x_approved_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
X-Approved: not the password
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('X-Approved' in self._msg.get_payload())
def test_removes_x_approve_pseudo_header_wrong_password(self):
self._msg.set_payload("""\
X-Approve: not the password
""")
self._rule.check(self._mlist, self._msg, {})
self.assertFalse('X-Approve' in self._msg.get_payload())
class TestApprovedPseudoHeaderMIME(unittest.TestCase):
"""Test the approved handler."""
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
self._mlist.moderator_password = config.password_context.encrypt(
'super secret')
self._rule = approved.Approved()
self._msg_text_template = """\
From: anne@example.com
To: test@example.com
Subject: A Message with non-ascii body
Message-ID: <ant>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="AAA"
--AAA
Content-Type: application/x-ignore
{0}: not the password
The above line will be ignored.
--AAA
Content-Type: text/plain
{0}: {1}
An important message.
"""
def test_approved_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('Approved', 'super secret'))
result = self._rule.check(self._mlist, msg, {})
self.assertTrue(result)
def test_approve_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('Approve', 'super secret'))
result = self._rule.check(self._mlist, msg, {})
self.assertTrue(result)
def test_x_approved_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('X-Approved', 'super secret'))
result = self._rule.check(self._mlist, msg, {})
self.assertTrue(result)
def test_x_approve_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('X-Approve', 'super secret'))
result = self._rule.check(self._mlist, msg, {})
self.assertTrue(result)
def test_approved_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('Approved', 'not password'))
result = self._rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_approve_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('Approve', 'not password'))
result = self._rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_x_approved_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('X-Approved', 'not password'))
result = self._rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_x_approve_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('X-Approve', 'not password'))
result = self._rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_removes_approved_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('Approved', 'super secret'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('Approved' in msg.get_payload(1).get_payload())
def test_removes_approve_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('Approve', 'super secret'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('Approve' in msg.get_payload(1).get_payload())
def test_removes_x_approved_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('X-Approved', 'super secret'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('X-Approved' in msg.get_payload(1).get_payload())
def test_removes_x_approve_pseudo_header_mime(self):
msg = mfs(self._msg_text_template.format('X-Approve', 'super secret'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('X-Approve' in msg.get_payload(1).get_payload())
def test_removes_approved_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('Approved', 'not password'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('Approved' in msg.get_payload(1).get_payload())
def test_removes_approve_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('Approve', 'not password'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('Approve' in msg.get_payload(1).get_payload())
def test_removes_x_approved_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('X-Approved', 'not password'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('X-Approved' in msg.get_payload(1).get_payload())
def test_removes_x_approve_pseudo_header_wrong_password_mime(self):
msg = mfs(self._msg_text_template.format('X-Approve', 'not password'))
self._rule.check(self._mlist, msg, {})
self.assertFalse('X-Approve' in msg.get_payload(1).get_payload())
class TestApprovedNonASCII(unittest.TestCase):
"""Test the approved handler with non-ascii messages."""
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
self._rule = approved.Approved()
self._msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A Message with non-ascii body
Message-ID: <ant>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
This is a message body with a non-ascii character =E4
""")
def test_nonascii_body_missing_header(self):
# When the message body contains non-ascii, the rule should not throw
# unicode errors. LP: #949924.
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
class TestPasswordHashMigration(unittest.TestCase):
"""Test that password hashing migrations work."""
# http://packages.python.org/passlib/lib/passlib.context-tutorial.html#integrating-hash-migration
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
# The default testing hash algorithm is "roundup_plaintext" which
# yields hashed passwords of the form: {plaintext}abc
#
# Migration is automatically supported when a more modern password
# hash is chosen after the original password is set. As long as the
# old password still validates, the migration happens automatically.
self._mlist.moderator_password = config.password_context.encrypt(
b'super secret')
self._rule = approved.Approved()
self._msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A Message with non-ascii body
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
def test_valid_password_migrates(self):
# Now that the moderator password is set, change the default password
# hashing algorithm. When the old password is validated, it will be
# automatically migrated to the new hash.
self.assertEqual(self._mlist.moderator_password,
b'{plaintext}super secret')
config_file = os.path.join(config.VAR_DIR, 'passlib.config')
# XXX passlib seems to choose the default hashing scheme even if it is
# deprecated. The default scheme is either specified explicitly, or
# is the first in this list. This seems like a bug.
with open(config_file, 'w') as fp:
print("""\
[passlib]
schemes = roundup_plaintext, plaintext
default = plaintext
deprecated = roundup_plaintext
""", file=fp)
with configuration('passwords', configuration=config_file):
self._msg['Approved'] = 'super secret'
result = self._rule.check(self._mlist, self._msg, {})
self.assertTrue(result)
self.assertEqual(self._mlist.moderator_password, b'super secret')
def test_invalid_password_does_not_migrate(self):
# Now that the moderator password is set, change the default password
# hashing algorithm. When the old password is invalid, it will not be
# automatically migrated to the new hash.
self.assertEqual(self._mlist.moderator_password,
b'{plaintext}super secret')
config_file = os.path.join(config.VAR_DIR, 'passlib.config')
# XXX passlib seems to choose the default hashing scheme even if it is
# deprecated. The default scheme is either specified explicitly, or
# is the first in this list. This seems like a bug.
with open(config_file, 'w') as fp:
print("""\
[passlib]
schemes = roundup_plaintext, plaintext
default = plaintext
deprecated = roundup_plaintext
""", file=fp)
with configuration('passwords', configuration=config_file):
self._msg['Approved'] = 'not the password'
result = self._rule.check(self._mlist, self._msg, {})
self.assertFalse(result)
self.assertEqual(self._mlist.moderator_password,
b'{plaintext}super secret')
|
