1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
|
# Copyright (C) 2016-2017 by the Free Software Foundation, Inc.
#
# This file is part of GNU Mailman.
#
# GNU Mailman is free software: you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free
# Software Foundation, either version 3 of the License, or (at your option)
# any later version.
#
# GNU Mailman is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
# more details.
#
# You should have received a copy of the GNU General Public License along with
# GNU Mailman. If not, see <http://www.gnu.org/licenses/>.
"""Test the DMARC handler."""
import unittest
from mailman.app.lifecycle import create_list
from mailman.app.membership import add_member
from mailman.handlers import dmarc
from mailman.interfaces.mailinglist import DMARCMitigateAction, ReplyToMunging
from mailman.interfaces.subscriptions import RequestRecord
from mailman.testing.helpers import specialized_message_from_string as mfs
from mailman.testing.layers import ConfigLayer
class TestDMARCMitigations(unittest.TestCase):
"""Test the dmarc handler."""
layer = ConfigLayer
maxDiff = None
def setUp(self):
self._mlist = create_list('ant@example.com')
self._mlist.anonymous_list = False
self._mlist.dmarc_policy_mitigate_action = (
DMARCMitigateAction.no_mitigation)
self._mlist.dmarc_wrapped_message_text = ''
self._mlist.dmarc_mitigate_unconditionally = False
self._mlist.reply_goes_to_list = ReplyToMunging.no_munging
# We can use the same message text for most tests.
self._text = """\
From: anne@example.com
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
"""
def test_default_no_change(self):
msg = mfs(self._text)
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_anonymous_no_change(self):
self._mlist.anonymous_list = True
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_no_mitigation_no_change_1(self):
msg = mfs(self._text)
self._mlist.dmarc_mitigate_unconditionally = True
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_no_mitigation_no_change_2(self):
msg = mfs(self._text)
msgdata = {'dmarc': True}
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_action_reject_mitigate_unconditionally(self):
msg = mfs(self._text)
self._mlist.dmarc_mitigate_unconditionally = True
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.reject
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_action_discard_mitigate_unconditionally(self):
msg = mfs(self._text)
self._mlist.dmarc_mitigate_unconditionally = True
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.discard
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_action_munge_from(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: anne--- via Ant <ant@example.com>
Reply-To: anne@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_action_munge_from_no_from(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = dict(
dmarc=True,
original_sender='anne@example.com',
)
msg = mfs(self._text)
del msg['from']
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: anne--- via Ant <ant@example.com>
Reply-To: anne@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_action_munge_multiple_froms(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = dict(
dmarc=True,
original_sender='cate@example.com',
)
msg = mfs(self._text)
# Put multiple addresses in the From: header. The msgdata must
# contain a key naming the "original sender" as determined by the
# Message.sender attribute.
del msg['from']
msg['From'] = 'anne@example.com, bart@example.com'
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: cate--- via Ant <ant@example.com>
Reply-To: cate@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_action_munge_from_display_name_in_from(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = {'dmarc': True}
msg = mfs(self._text)
del msg['from']
msg['From'] = 'Anne Person <anne@example.com>'
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: Anne Person via Ant <ant@example.com>
Reply-To: Anne Person <anne@example.com>
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_action_munge_from_display_name_in_list(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
add_member(
self._mlist,
RequestRecord('anne@example.com', 'Anna Banana')
)
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: Anna Banana via Ant <ant@example.com>
Reply-To: anne@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_no_action_without_msgdata(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msg = mfs(self._text)
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), self._text)
def test_unconditional_no_msgdata(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
self._mlist.dmarc_mitigate_unconditionally = True
msg = mfs(self._text)
dmarc.process(self._mlist, msg, {})
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: anne--- via Ant <ant@example.com>
Reply-To: anne@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_from_in_cc(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
self._mlist.reply_goes_to_list = ReplyToMunging.point_to_list
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: anne--- via Ant <ant@example.com>
Cc: anne@example.com
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
def test_wrap_message_unconditionally(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.wrap_message
self._mlist.dmarc_mitigate_unconditionally = True
msg = mfs(self._text)
dmarc.process(self._mlist, msg, {})
# We can't predict the Message-ID in the wrapper so delete it, but
# ensure we have one.
self.assertIsNotNone(msg.get('message-id'))
del msg['message-id']
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Date: Fri, 1 Jan 2016 00:00:01 +0000
MIME-Version: 1.0
From: anne--- via Ant <ant@example.com>
Reply-To: anne@example.com
Content-Type: message/rfc822
Content-Disposition: inline
""" + self._text)
def test_wrap_message(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.wrap_message
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
# We can't predict the Message-ID in the wrapper so delete it, but
# ensure we have one.
self.assertIsNotNone(msg.get('message-id'))
del msg['message-id']
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Date: Fri, 1 Jan 2016 00:00:01 +0000
MIME-Version: 1.0
From: anne--- via Ant <ant@example.com>
Reply-To: anne@example.com
Content-Type: message/rfc822
Content-Disposition: inline
""" + self._text)
def test_wrap_message_cc(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.wrap_message
self._mlist.reply_goes_to_list = ReplyToMunging.point_to_list
msgdata = {'dmarc': True}
msg = mfs(self._text)
dmarc.process(self._mlist, msg, msgdata)
# We can't predict the Message-ID in the wrapper so delete it, but
# ensure we have one.
self.assertIsNotNone(msg.get('message-id'))
del msg['message-id']
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Date: Fri, 1 Jan 2016 00:00:01 +0000
MIME-Version: 1.0
From: anne--- via Ant <ant@example.com>
Cc: anne@example.com
Content-Type: message/rfc822
Content-Disposition: inline
""" + self._text)
def test_rfc2047_encoded_from(self):
self._mlist.dmarc_mitigate_action = DMARCMitigateAction.munge_from
msgdata = {'dmarc': True}
msg = mfs(self._text)
del msg['from']
msg['From'] = '=?iso-8859-1?Q?A_Pers=F3n?= <anne@example.com>'
dmarc.process(self._mlist, msg, msgdata)
self.assertMultiLineEqual(msg.as_string(), """\
To: ant@example.com
Subject: A subject
X-Mailman-Version: X.Y
Message-ID: <alpha@example.com>
Date: Fri, 1 Jan 2016 00:00:01 +0000
Another-Header: To test removal in wrapper
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=====abc=="
From: =?utf-8?q?A_Pers=C3=B3n_via_Ant?= <ant@example.com>
Reply-To: =?iso-8859-1?Q?A_Pers=F3n?= <anne@example.com>
--=====abc==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Some things to say.
--=====abc==
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: 7bit
<html><head></head><body>Some things to say.</body></html>
--=====abc==--
""")
|
