| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| | |
|
| |
|
|
|
|
| |
easier to test, and to use in other tests. Do this by moving most of the guts
of master.py into a class that can be subclassed, and thus run in a subthread
to avoid blocking the test. We don't need to sleep anymore.
|
| | |
|
| |
|
|
| |
wasn't waiting on all the children before it exited itself.
|
| |
|
|
|
|
|
|
|
|
|
| |
this considerably, since it now just checks the permissions, handles command
parsing, and then just (in the child) execs master.py. master.py handles the
log files, etc.
Added 'BIN_DIR' to the configuration object. Remove references to
instance.cfg in the comments; that was never implemented.
I still need tests for both mailmanctl and master.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functionality of mailmanctl into a separate master watcher script. mailmanctl
has not yet been updated but that'll happen next.
Fix DELIVERY_MODULE to name a handler instead of a module.
Change make_instance to use pkg_resources instead of module.__file__.
Change the qrunner and master processes coordination so that the qrunners are
not restarted on SIGINT, because otherwise C-c just doesn't work. Now SIGUSR1
is how we'll implement 'mailman restart'.
Add a database commit so that initializing the schema doesn't lock the sqlite
database. Also, don't try to initialize the schema if the tables already
exist. Use some sqlite magic to do this test.
Move mailman.cfg.in into a new package Mailman/extras inside the tree. Also,
MAILMAN_UID and MAILMAN_GID should be integers not strings.
Convert the command runner to use an IHandler instance instead of handler
module. Similarly for the outgoing runner, DELIVERY_MODULE now names an
IHandler instance instead of a handler module.
|
| |
|
|
|
|
|
|
|
| |
this module, in favor of moving exceptions into the interface modules that
they are appropriate for.
For now, this is just the low-hanging fruit.
Along the way, clean up by reSTifying some interfaces and implementations.
|
| |
|
|
| |
No more %-strings. Kill off all __i18n_templates__ hacks.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
the built-in pipeline.
Fixed DEFAULT_SUBJECT_PREFIX to take $-names instead of %-names, although I'm
not entirely sure the %%d stuff still works (we need a test for this).
Added IMailingList.real_name attribute and added this to the default style. A
column for this was in the database but not in the storm object. Also
re-enabled the style's subject_prefix attribute.
Moved some of the digest test functions into Mailman.tests.helpers.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now plugins can define additional handlers and the handlers can be organized
into named pipelines. Modules are no longer the unit of a handler, now we use
classes so we can assert interface conformance.
The GLOBAL_PIPELINE is gone, replaced by the 'built-in' pipeline. The
OWNER_PIPELINE is not yet replaced.
I still need a few more tests of the basic pipeline architecture, although the
individual handlers have pretty good coverage.
Added the IHandler and IPipeline interfaces.
Still broken, but not yet removed: Mailman/pipeline/moderate.py.
|
| | |
|
| |
|
|
| |
Add a pipeline queue runner.
|
| | |
|
| |
|
|
| |
Rename all handlers to be more PEP 8 friendly, i.e. lowercased.
|
| |
|
|
|
|
|
| |
support unicode. Although this never bit me on OS X (Leopard) it matters
greatly on Linux (Ubuntu) where you get lots of test failures because of it.
So instead, just use 8-bit string in message_from_string(). Everything works
fine still.
|
| |
|
|
|
|
|
| |
Added a Mailman.tests.helpers module for some commonly used stuff (although
test refactoring hasn't yet happened).
Give Mailman 3.0a1 a code name.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the big explanatory text at the beginning of incoming.py to a doctest called
OVERVIEW.tt (which doesn't actually contain any tests yet -- it's
documentation though).
Added a doctest for the incoming runner, though this will be fleshed out in
more detail next.
Mailman.Post renamed to Mailman.inject, and simplified. We don't need its
command line script behavior because that is now handled by bin/inject.
Add a 'start_chain' attribute to mailing lists. This names the chain that
processing of messages for that list begins with.
We were inconsistent in the use of the 'no reply' address attribute. It's now
always 'no_reply_address'.
Update the smtplistener helper with lessons learned about how to suppress
bogus asyncore error messages. Also, switch to using a maildir mailbox
instead of an mbox mailbox.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
success and will now be merged into the trunk.
Move the Truth rule into the built-in rules package in a separate module, and
add a test.
Modify IChainLink so that the rule and chain attributes are not names but
indeed the actual ILink or IChain object directly. Update the
chains.process() function accordingly. Remove the IChain.get_rule() method.
Don't derive BuiltInChain from Chain and don't make it an IMutableChain. It's
now just an IChain, and is implemented concretely.
Refactor the HeaderMatchChain and friends so that it can be used with both the
global HEADER_MATCHES variable and the list-specific header_matches variable,
which has exactly the same semantics. Oh yeah, get rid of the list's
header_filter_rules attribute and replace it with header_matches so that the
semantics match, it's easy to explain, and it's all nice and clean.
|
| |
|
|
|
|
|
|
|
|
|
| |
Create a Mailman.chains package and move a bunch of the Mailman.apps.chains
classes to separate modules under this package.
Also, separate out iteration from chain management. In other words, IChain
and IChainIterator are separate, and the latter is retrieved from the former
by the .get_links() method. This latter takes the mailing list, message, and
metadata dictionary so that links can be targetted specifically to the task at
hand.
|
| |
|
|
|
| |
Create a Mailman.chains package and move a bunch of the Mailman.apps.chains
classes to separate modules under this package.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
variable to the new chain processing system. Create a header-matching chain
which handles global site header matching rules defined by HEADER_MATCHES.
Rip this logic out of the SpamDetect handler; really this entire handler needs
to go away but the rest of it isn't ported yet.
IChains now have a get_rule() method which allows them to return private
(i.e. not globally registered) rules. This is used by the header matching
chain.
Mailman.app.chains.process() has had its parameter list reordered to be more
like all other function signatures that take a mailing list, message, and
message metadata.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Now a link has a rule, action, chain, and function, not all of which needs to
be specified. The action is a LinkAction enum adn specifies what to do should
the rule match. The use of the chain or function depends on what the action
is.
Several interface changes now make it easier to jump to other chains, push
(i.e. detour) to chains, etc. Rules can also now specify that they should not
be recorded in X-* headers.
Added a TruthRule which always matches.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the Emergency.py handler. This is now covered by the emergency.py
rule.
- Remove the hold.txt doctest. This is now covered by the chains.txt and
emergency.txt doctests.
- Added a chains.txt doctest.
- Extend the pending db to handle list values, although only lists that
contain nothing but strings.
- Rename the 'adminapproved' message metadata key (for the emergency rule) to
'moderator_approved'.
Also, backport a change to the Decorate handler where message metadata on the
'decoration-data' key ca be used in the header and footer.
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
to the archiver. Also add a plugin architecture for easily overriding the
archiver, and hook this into the setup.py script.
Updated CookHeaders.py and Scrubber.py handlers to use the plugged archiver.
Updated doctests as appropriate.
Fix a typo in the setup.py file.
|
| | |
| |
| |
| | |
<wink> works around the storm cache bug #178546.
|
| | |
| |
| |
| | |
<wink> works around the storm cache bug #178546.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
they are instantiated by the IRuleSet, thus keeping the promises of the
interface.
The ChainJump enum is moved to interfaces/chain.py. This will be fleshed out
subsequently.
|
| | |
| |
| |
| |
| |
| | |
called 'docs' anywhere under the Mailman package. Change the rule API to
return rule classes not instances. Added the ChainJump enum, though this will
likely change soon.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
- A rule that checks to see if the sender is a moderated member.
- A rule that checks to see if the sender is a non-member.
- A rule that checks to see if the message has no (or an empty) Subject.
Give IMembers (and the associated database implementation) an `is_moderated`
flag.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Rename the implicit.txt doctest.
specialized_message_from_string(): Mimic the way the text->message parser will
include the size of the original text as an attribute on the message object.
The maximum message size rule will use this information.
|
| | |
| |
| |
| |
| |
| | |
bunch of doctests. Note that the old Hold Notification tests are temporarily
disabled as these will have to be rewritten when the rule matching logic gets
added.
|
| | | |
|
| | |
| |
| |
| | |
rule. Add doctest as appropriate.
|
| | |
| |
| |
| |
| |
| | |
rule. Add doctest as appropriate.
DEFAULT_MAIL_COMMANDS_MAX_LINES -> EMAIL_COMMANDS_MAX_LINES
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
use the rule check instead of handler processing. Add a test for stripping
the header from the text/html part to the doctest.
Add Mailman.app.rules.find_rule() to return a named rule.
Fix a few typos.
|
| | |
| |
| |
| |
| |
| | |
they do not do the actual rule processing. That's left up to Mailman.
Further, the rule processor can be given a list of rules to run; those will be
the only ones run.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
The basic idea is that we process rules on a mlist, message, metadata triplet
making a list of all rules that hit. Then a different part of the system will
decide on the disposition of a message based on which rules hit and their
priority.
The doctest and plugin architecture is in place, including the tie-in to
setup.py. Ported the first rule -- emergency.py -- to the new rule
processor.
We no longer need SQLAlchemy as a requirement, and the setuptools/bzr plugin
name has changed.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
values are unicodes if they come from the base class as a string.
Get rid of the 'global id'. Now use just Message-ID. Rename
X-List-ID-Hash to X-Message-ID-Hash. Do not take Date header into
account when calculating this hash.
Because of the above change, the assumption is that there will be no
Message-ID collisions. Therefore, get rid of IMessageStore
.get_message(), .get_messages_by_message_id() and
.get_messages_by_hash(). Instead, it's now .get_message_by_id() and
.get_message_by_hash() both of which return the message object or
None.
Message.hash -> Message.message_id_hash
When storing a message in the message store, the final path component
has the entire hash, not just the leftover parts after directory
prefix splitting.
MessageStore.delete_message() deletes the file too.
Doctests clean up message store messages though the message store
instead of directly off the filesystem.
|
| |
|
|
|
| |
subdirectory and updating all relevant imports. Move of the circular
import problems have been eliminated in the process.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
reasons for this, but most importantly, the changes from SQLAlchemy/Elixir 0.3
to 0.4 were substantial and caused a lot of work. This work unfortunately did
not result in a working branch due to very strange and inconsistent behavior
with Unicode columns. Sometimes such columns would return Unicode, sometimes
8-bit strings, with no rhyme or reason. I gave up debugging this after many
hours of head scratching.
Oh yeah, no more flush!
Storm enforces Unicode columns, which is very nice, though requires us to add
lots of 'u's in places we didn't have them before. Ultimately, this is a good
thing so that the core of Mailman will be Unicode consistent.
One thing I still want to clean up after this, is the function-scoped imports
in the model code. Part of the reason for the separate model classes was to
avoid this, but for now, we'll live with it. Storm's architecture requires us
to maintain a database-table-class registry for simple clearing after tests
in Database._reset(). This is made fairly simple by Storm allowing us to use
our own metaclass for model classes.
Storm does require that we write our own SQL files, which is a downside, but I
think our schema will be easy enough that this won't be a huge burden. Plus
we have a head-start <wink>.
Another cool thing about Storm is the explicit use of stores for objects.
This should eventually allow me to flesh out my idea of storage pillars for 1)
lists, 2) users, 3) messages.
Some other changes:
- pylint and pyflakes cleanups
- SQLALCHEMY_ENGINE_URL -> DEFAULT_DATABASE_URL
- Don't import-* from Version in Defaults.py
- Add interface method to Mailman.Message.Message so that __getitem__() and
get_all() always return Unicode headers, even when the underlying objects
are strings. This should generally be safe as headers are required by RFC
to be within the ASCII range.
- Fix bin/arch.py to use proper initialization.
|
| | |\ |
|
| | |/ |
|