summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--Mailman/Handlers/Approve.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/Mailman/Handlers/Approve.py b/Mailman/Handlers/Approve.py
index 8ebfd58aa..d0112e6fe 100644
--- a/Mailman/Handlers/Approve.py
+++ b/Mailman/Handlers/Approve.py
@@ -36,7 +36,9 @@ def process(mlist, msg, msgdata):
# above may not be entirely correct.
return
# See if the message has an Approved: or Approve: header with a valid
- # list-moderator, list-admin, or site-admin password
+ # list-moderator, list-admin. We are specifically /not/ allowing the site
+ # admins password to work here because we want to discourage the practice
+ # of sending the site admin password through email in the clear.
missing = []
passwd = msg.get('approved', msg.get('approve', missing))
if passwd is not missing and mlist.Authenticate((mm_cfg.AuthListModerator,