Several internal improvements:

* New events:
  - ConfirmationNeededEvent is triggered when a pendable requiring
    confirmation is created.  This allows us to define an event handler for
    this event which sends the user notification.
  - SubscriptionEvent is triggered when a member is added to a mailing list.
    This lets us define an event handler which sends the welcome message.
* send_welcome_message() now takes a member parameter instead of an address,
  which lets us directly access the member's delivery mode and user display
  name (if the member has a user, which it might not in some cases).
* Use the list id in the pendable record instead of the list name for
  robustness (the latter can change but the former is permanent).
* Test more registration conditions.
* In the bin/runner command line switch handling, default `verbose` to None
  instead of False.  This makes it work better with nose's -E switch (log to
  stderr).
* In call_api(), if a POST, PUT, or PATCH method is used and data is None,
  encode the empty dictionary; seems like the behavior of urlencode() has
  changed, so this is safer.
* Fix style and pyflakes warnings.

1 files changed, 2 insertions, 3 deletions

diff --git a/src/mailman/commands/tests/test_confirm.py b/src/mailman/commands/tests/test_confirm.py
index 513a541b0..19a9068bc 100644
--- a/src/mailman/commands/tests/test_confirm.py
+++ b/src/mailman/commands/tests/test_confirm.py
@@ -55,11 +55,10 @@ class TestConfirm(unittest.TestCase):
 
     def tearDown(self):
         reset_the_world()
-        
+
     def test_welcome_message(self):
         # A confirmation causes a welcome message to be sent to the member, if
         # enabled by the mailing list.
-        #
         status = self._command.process(
             self._mlist, Message(), {}, (self._token,), Results())
         self.assertEqual(status, ContinueProcessing.yes)
@@ -68,7 +67,7 @@ class TestConfirm(unittest.TestCase):
         self.assertEqual(len(messages), 1)
         # Grab the welcome message.
         welcome = messages[0].msg
-        self.assertEqual(welcome['subject'], 
+        self.assertEqual(welcome['subject'],
                          'Welcome to the "Test" mailing list')
         self.assertEqual(welcome['to'], 'Anne Person <anne@example.com>')