Don't use `flake8: noqa`.

This suppresses all errors in the file.  Use `noqa`, although pep8
doesn't honor this for all errors.

There may be a plugin which helps.

5 files changed, 13 insertions, 13 deletions

diff --git a/src/mailman/chains/hold.py b/src/mailman/chains/hold.py
index 329bbc71b..3a8284a78 100644
--- a/src/mailman/chains/hold.py
+++ b/src/mailman/chains/hold.py
@@ -163,10 +163,10 @@ class HoldChain(TerminalChainBase):
             bytes_subject = oneline_subject.encode(charset, 'replace')
             original_subject = bytes_subject.decode(charset)
         substitutions = dict(
-            listname    = mlist.fqdn_listname,         # flake8: noqa
-            subject     = original_subject,            # flake8: noqa
-            sender      = msg.sender,                  # flake8: noqa
-            reasons     = _compose_reasons(msgdata),   # flake8: noqa
+            listname    = mlist.fqdn_listname,         # noqa
+            subject     = original_subject,            # noqa
+            sender      = msg.sender,                  # noqa
+            reasons     = _compose_reasons(msgdata),   # noqa
             )
         # At this point the message is held, but now we have to craft at least
         # two responses.  The first will go to the original author of the
diff --git a/src/mailman/chains/reject.py b/src/mailman/chains/reject.py
index f0926cd8c..934b83b3d 100644
--- a/src/mailman/chains/reject.py
+++ b/src/mailman/chains/reject.py
@@ -64,8 +64,8 @@ reasons:
 
 The original message as received by Mailman is attached.
 """).format(
-    list_name=mlist.display_name,                   # flake8: noqa
-    reasons=NEWLINE.join(reasons)                   # flake8: noqa
+    list_name=mlist.display_name,                   # noqa
+    reasons=NEWLINE.join(reasons)                   # noqa
     ))
         bounce_message(mlist, msg, error)
         log.info('REJECT: %s', msg.get('message-id', 'n/a'))
diff --git a/src/mailman/chains/tests/test_accept.py b/src/mailman/chains/tests/test_accept.py
index 661ad2146..9b7a25fab 100644
--- a/src/mailman/chains/tests/test_accept.py
+++ b/src/mailman/chains/tests/test_accept.py
@@ -60,7 +60,7 @@ Subject: Ignore
         config.chains['mine'] = MyChain()
         self.addCleanup(config.chains.pop, 'mine')
         hits = None
-        def handler(event):                         # flake8: noqa
+        def handler(event):                         # noqa
             nonlocal hits
             if isinstance(event, AcceptEvent):
                 hits = event.msg['x-mailman-rule-hits']
diff --git a/src/mailman/chains/tests/test_headers.py b/src/mailman/chains/tests/test_headers.py
index b3ccdf675..246462d5f 100644
--- a/src/mailman/chains/tests/test_headers.py
+++ b/src/mailman/chains/tests/test_headers.py
@@ -168,7 +168,7 @@ class TestHeaderChain(unittest.TestCase):
             [('foo', 'a+', LinkAction.jump, 'reject'),
              ('bar', 'b+', LinkAction.jump, 'discard'),
              ('baz', 'z+', LinkAction.jump, 'accept'),
-            ])                                      # flake8: noqa
+            ])                                      # noqa
 
     @configuration('antispam', header_checks="""
     Foo: foo
@@ -218,7 +218,7 @@ A message body.
         # This event subscriber records the event that occurs when the message
         # is processed by the owner chain, which holds its for approval.
         events = []
-        def record_holds(event):                    # flake8: noqa
+        def record_holds(event):                    # noqa
             if not isinstance(event, HoldEvent):
                 return
             events.append(event)
@@ -226,7 +226,7 @@ A message body.
             # Set the site-wide antispam action to hold the message.
             with configuration('antispam', header_checks="""
                 Spam: [*]{3,}
-                """, jump_chain='hold'):            # flake8: noqa
+                """, jump_chain='hold'):            # noqa
                 process(self._mlist, msg, {}, start_chain='header-match')
             self.assertEqual(len(events), 1)
             event = events[0]
@@ -235,7 +235,7 @@ A message body.
             self.assertEqual(event.mlist, self._mlist)
             self.assertEqual(event.msg, msg)
         events = []
-        def record_discards(event):                 # flake8: noqa
+        def record_discards(event):                 # noqa
             if not isinstance(event, DiscardEvent):
                 return
             events.append(event)
@@ -244,7 +244,7 @@ A message body.
             msg.replace_header('Message-Id', '<bee>')
             with configuration('antispam', header_checks="""
                 Spam: [*]{3,}
-                """, jump_chain='discard'):         # flake8: noqa
+                """, jump_chain='discard'):         # noqa
                 process(self._mlist, msg, {}, start_chain='header-match')
             self.assertEqual(len(events), 1)
             event = events[0]
diff --git a/src/mailman/chains/tests/test_owner.py b/src/mailman/chains/tests/test_owner.py
index 06ba10582..004c0200a 100644
--- a/src/mailman/chains/tests/test_owner.py
+++ b/src/mailman/chains/tests/test_owner.py
@@ -50,7 +50,7 @@ Message-ID: <ant>
         # This event subscriber records the event that occurs when the message
         # is processed by the owner chain.
         events = []
-        def catch_event(event):                                 # flake8: noqa
+        def catch_event(event):                                 # noqa
             if isinstance(event, AcceptOwnerEvent):
                 events.append(event)
         with event_subscribers(catch_event):