Sprinkle a few more transaction API calls around to make sure the database

doesn't remain in a locked state, hosing other processes.

- Move a commit to the end of StockDatabase._create()
- Add an abort to the Exception clause if there's an error while dequeuing
- Add an abort to the Exception clause if there's an error while finishing
- Add a commit after _doperiodic() and _shortcircuit() is called.
- Add a commit to the end of cleaning_teardown() in test_documentation.py

This now makes all the tests pass even when all of them are run.

1 files changed, 1 insertions, 1 deletions

diff --git a/mailman/database/__init__.py b/mailman/database/__init__.py
index dabe70c79..1f73071c0 100644
--- a/mailman/database/__init__.py
+++ b/mailman/database/__init__.py
@@ -121,7 +121,6 @@ class StockDatabase:
                 sql = fp.read()
             for statement in sql.split(';'):
                 store.execute(statement + ';')
-            store.commit()
         # Validate schema version.
         v = store.find(Version, component=u'schema').one()
         if not v:
@@ -133,6 +132,7 @@ class StockDatabase:
             # XXX Update schema
             raise SchemaVersionMismatchError(v.version)
         self.store = store
+        store.commit()
 
     def _reset(self):
         """See `IDatabase`."""