summaryrefslogtreecommitdiff
path: root/Mailman/pythonlib
diff options
context:
space:
mode:
authorbwarsaw1999-01-08 06:04:22 +0000
committerbwarsaw1999-01-08 06:04:22 +0000
commita34762ab857cc7e2fd37ac84ca5ccf58b2cfcbe6 (patch)
tree3bf72d161e6610085b2a1ec0b350a6530b9f777e /Mailman/pythonlib
parent52ee9e7e8c15e50a5be19b1a7fa0247270e0d516 (diff)
downloadmailman-a34762ab857cc7e2fd37ac84ca5ccf58b2cfcbe6.tar.gz
mailman-a34762ab857cc7e2fd37ac84ca5ccf58b2cfcbe6.tar.zst
mailman-a34762ab857cc7e2fd37ac84ca5ccf58b2cfcbe6.zip
Diffstat (limited to 'Mailman/pythonlib')
-rwxr-xr-xMailman/pythonlib/cgi.py26
1 files changed, 24 insertions, 2 deletions
diff --git a/Mailman/pythonlib/cgi.py b/Mailman/pythonlib/cgi.py
index 108310ebd..ab6dda843 100755
--- a/Mailman/pythonlib/cgi.py
+++ b/Mailman/pythonlib/cgi.py
@@ -828,9 +828,23 @@ class FieldStorage:
self.filename = pdict['filename']
# Process content-type header
- ctype, pdict = "text/plain", {}
+ #
+ # Honor any existing content-type header. But if there is no
+ # content-type header, use some sensible defaults. Assume
+ # outerboundary is "" at the outer level, but something non-false
+ # inside a multi-part. The default for an inner part is text/plain,
+ # but for an outer part it should be urlencoded. This should catch
+ # bogus clients which erroneously forget to include a content-type
+ # header.
+ #
+ # See below for what we do if there does exist a content-type header,
+ # but it happens to be something we don't understand.
if self.headers.has_key('content-type'):
ctype, pdict = parse_header(self.headers['content-type'])
+ elif self.outerboundary:
+ ctype, pdict = "text/plain", {}
+ else:
+ ctype, pdict = 'application/x-www-form-urlencoded', {}
self.type = ctype
self.type_options = pdict
self.innerboundary = ""
@@ -853,8 +867,16 @@ class FieldStorage:
self.read_urlencoded()
elif ctype[:10] == 'multipart/':
self.read_multi(environ, keep_blank_values, strict_parsing)
- else:
+ elif self.outerboundary:
+ # we're in an inner part, but the content-type wasn't something we
+ # understood. default to read_single() because the resulting
+ # FieldStorage won't be a mapping (and doesn't need to be).
self.read_single()
+ else:
+ # we're in an outer part, but the content-type wasn't something we
+ # understood. we still want the resulting FieldStorage to be a
+ # mapping, so parse it as if it were urlencoded
+ self.read_urlencoded()
def __repr__(self):
"""Return a printable representation."""