It all started by trying to remove MailList.Create() and use the IListManager

interface to create and delete lists.  Mostly that's working now, but I need
unit tests for most of the new work contained in this revision.

Implemented a rudimentary 'list styles' subsystem, along with interfaces, but
no tests yet.  Moved all of MailList.InitVars() into a DefaultStyle, which is
always available at priority zero.  It's used by default if there are no
matching styles for a mailing list.

Because of the list styles, we can now get rid of (almost) all InitVars()
methods.  And because of /that/ we can get rid of the mixin clases whose sole
purpose was to provide an InitVars() method.  Yay for code removal!

Mixin modules/classes removed: Autoresponder, GatewayManager, TopicManager.

Removed the Mailman/ext crufty extension mechanism.  Extensions will now be
done using setuptools plugins.  Hopefully this will take us everywhere we need
to go, but I'll add Mailman.ext back if necessary later.

Mailiman.app.create module added to implement a common, higher-level list
creation feature.  This is used by bin/newlist now, though some of that
functionality (namely, ensuring the owners exist in the database, and
notifying the owners) should be moved here.   The MTA plugins aren't yet
integrated into this, but need to be.

Mailman.app.plugins module added to generalize setuptools plugin management.

Defaults.DEFAULT_REPLY_GOES_TO_LIST now gets initialized with a proper enum.
Also, the duplicate DeliveryMode and DeliveryStatus enums are removed from
Defaults because they're in Mailman.constants.

Added Errors.DuplicateStyleError.

Updated Utils.list_exists() to use the new IListManager.get() interface, which
has been changed to return None if the list doesn't exist (for consistency)
instead of raising an exception.  Utils.list_names() also needed to be fixed
to use config.db.list_manager.

bin/make_instance, bin/newlist, bin/rmlist changed to use parser.error()
istead of printing to sys.stderr and sys.exit(1).

bin/newlist and bin/rmlist now works with the IListManager interface, so you
can create and delete lists from the command line again.  The CLI for newlist
has been much simplified; it no longer prompts for missing positional
arguments.  It now uses a more traditional CLI.  newlist also accepts zero to
many owners, and it ensures that the owners are all in the database.  It no
longer asks for a list password, because this doesn't make sense any more.

bin/withlist has also been fixed to work with the IListManager interface.

There are lots of XXXs and FIXMEs that need to be resolved before this can
land.  Also, we need to test all this stuff before it can land.

Configuration.load() is now taught to search in sys.argv[0] for
var/etc/mailman.cfg since this is where it is for egg development layouts.
Also, VAR_DIR must be abspath'd.

Added an __all__ to Mailman.constants, and added an Action enum.

The listmanager implementation has to set the mlist.created_at time.  There's
also a bit of crufty refactoring going on to instantiate the roster objects
whenever the list is created or retrieved from the database.

Several MailingList column types are now set to our custom TimeDeltaType,
which knows how to store a datetime.timedelta.  A SQLAlchemny converter type
is added to Mailman.database.types.  I also fixed a bug in the EnumType
implementation.

1 files changed, 0 insertions, 58 deletions

diff --git a/Mailman/TopicMgr.py b/Mailman/TopicMgr.py
deleted file mode 100644
index 23f27d3ce..000000000
--- a/Mailman/TopicMgr.py
+++ /dev/null
@@ -1,58 +0,0 @@
-# Copyright (C) 2001-2007 by the Free Software Foundation, Inc.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
-# USA.
-
-"""This class mixes in topic feature configuration for mailing lists."""
-
-import re
-
-
-
-class TopicMgr:
-    def InitVars(self):
-        # Configurable
-        #
-        # `topics' is a list of 4-tuples of the following form:
-        #
-        #     (name, pattern, description, emptyflag)
-        #
-        # name is a required arbitrary string displayed to the user when they
-        # get to select their topics of interest
-        #
-        # pattern is a required verbose regular expression pattern which is
-        # used as IGNORECASE.
-        #
-        # description is an optional description of what this topic is
-        # supposed to match
-        #
-        # emptyflag is a boolean used internally in the admin interface to
-        # signal whether a topic entry is new or not (new ones which do not
-        # have a name or pattern are not saved when the submit button is
-        # pressed).
-        self.topics = []
-        self.topics_enabled = False
-        self.topics_bodylines_limit = 5
-        # Non-configurable
-        #
-        # This is a mapping between user "names" (i.e. addresses) and
-        # information about which topics that user is interested in.  The
-        # values are a list of topic names that the user is interested in,
-        # which should match the topic names in self.topics above.
-        #
-        # If the user has not selected any topics of interest, then the rule
-        # is that they will get all messages, and they will not have an entry
-        # in this dictionary.
-        self.topics_userinterest = {}