summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbwarsaw1999-03-23 16:56:41 +0000
committerbwarsaw1999-03-23 16:56:41 +0000
commitde753de0cb270bbc04dedc990961856ace25b290 (patch)
treed992b811abd79d93bf2a34f1060b9b811eb3339d
parente83495d03293ccf3932b65edc7fad6cd01c63b21 (diff)
downloadmailman-de753de0cb270bbc04dedc990961856ace25b290.tar.gz
mailman-de753de0cb270bbc04dedc990961856ace25b290.tar.zst
mailman-de753de0cb270bbc04dedc990961856ace25b290.zip
Deal with some BSD issues raised by Vivek Khera. First, add a README
file containing Vivek's comments. Second, in the Makefile.in, allow the installer to override the chmod command on the directories. -Barry
-rw-r--r--Makefile.in5
-rw-r--r--README.BSD25
2 files changed, 28 insertions, 2 deletions
diff --git a/Makefile.in b/Makefile.in
index e528849f4..7fa8a96ff 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -58,6 +58,7 @@ DIRMODE= 775
EXEMODE= 755
FILEMODE= 644
INSTALL_PROGRAM=$(INSTALL) -m $(EXEMODE)
+DIRSETGID= chmod g+s
# Rules
@@ -79,7 +80,7 @@ install: $(SUBDIRS)
echo "Creating directory hierarchy $$dir"; \
./mkinstalldirs $$dir; \
chmod $(DIRMODE) $$dir; \
- chmod g+s $$dir; \
+ $(DIRSETGID) $$dir; \
else true; \
fi; \
done
@@ -92,7 +93,7 @@ install: $(SUBDIRS)
echo "Creating directory hierarchy $$dir"; \
./mkinstalldirs $$dir; \
chmod $(DIRMODE) $$dir; \
- chmod g+s $$dir; \
+ $(DIRSETGID) $$dir; \
else true; \
fi; \
done
diff --git a/README.BSD b/README.BSD
new file mode 100644
index 000000000..c265d009c
--- /dev/null
+++ b/README.BSD
@@ -0,0 +1,25 @@
+Mailman - The GNU Mailing List Management System
+Copyright (C) 1998 by the Free Software Foundation, Inc.
+59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
+
+BSD ISSUES
+
+Vivek Khera writes that BSD does nightly security scans for setuid
+file changes. Setgid directories also come up on the scan when they
+change. He says that setgid bit is not necessary on BSD systems
+because group ownership is automatically inherited on files created in
+directories. On other Un*xes, this only happens when the directory
+has the setgid bit turned on.
+
+To install without turning on the setgid bit on directories, simply
+pass in the DIRSETGID variable to make, like so:
+
+ % make DIRSETGID=: install
+
+This turns off the chmod g+s on each directory as they are installed.
+
+
+Local Variables:
+mode: text
+indent-tabs-mode: nil
+End: