diff options
| author | Barry Warsaw | 2016-10-26 20:17:31 -0400 |
|---|---|---|
| committer | Barry Warsaw | 2016-10-26 20:18:42 -0400 |
| commit | d2f59ff1d0d2b30763529543a68b0a4fdb9e28c6 (patch) | |
| tree | d0b60041a47ab39bf56b3e932aaec8263d195f24 | |
| parent | d33516cd8f27ab763d6a81ac12c23afd351a2057 (diff) | |
| download | mailman-d2f59ff1d0d2b30763529543a68b0a4fdb9e28c6.tar.gz mailman-d2f59ff1d0d2b30763529543a68b0a4fdb9e28c6.tar.zst mailman-d2f59ff1d0d2b30763529543a68b0a4fdb9e28c6.zip | |
| -rw-r--r-- | src/mailman/docs/NEWS.rst | 3 | ||||
| -rw-r--r-- | src/mailman/model/tests/test_bans.py | 15 |
2 files changed, 11 insertions, 7 deletions
diff --git a/src/mailman/docs/NEWS.rst b/src/mailman/docs/NEWS.rst index 3c631525e..c7c76af0a 100644 --- a/src/mailman/docs/NEWS.rst +++ b/src/mailman/docs/NEWS.rst @@ -227,7 +227,8 @@ REST string in the REST API. Given by Aurélien Bompard. * A list's ``moderator_password`` can be set via the REST API. Given by Andrew Breksa. (Closes #207) - * Banned addresses can now be paginated. Given by Amit. (Closes #284) + * The ban manager now returns a pageable, sorted sequence. Given by Amit and + Aurélien Bompard. (Closes #284) * Query parameters now allow you to filter mailing lists by the ``advertised`` boolean parameter. Given by Aurélien Bompard. diff --git a/src/mailman/model/tests/test_bans.py b/src/mailman/model/tests/test_bans.py index 03cd6e2c2..8fab730a2 100644 --- a/src/mailman/model/tests/test_bans.py +++ b/src/mailman/model/tests/test_bans.py @@ -49,14 +49,17 @@ class TestMailingListBans(unittest.TestCase): def test_bans_sequence(self): # Bans returns a pageable sorted sequence. - self._manager.ban('ant@example.com') self._manager.ban('bee@example.com') + self._manager.ban('ant@example.com') + self._manager.ban('cat@example.com') # The results can be len()'d. - self.assertEqual(len(self._manager.bans), 2) + count = len(self._manager.bans) + self.assertEqual(count, 3) # The results can be iterated. - self.assertEqual(['ant@example.com', 'bee@example.com'], - [ban.email for ban in self._manager.bans]) + self.assertEqual( + ['ant@example.com', 'bee@example.com', 'cat@example.com'], + [ban.email for ban in self._manager.bans]) # The results can be indexed. self.assertEqual( - [self._manager.bans[0].email, self._manager.bans[1].email], - ['ant@example.com', 'bee@example.com']) + [self._manager.bans[i].email for i in range(count)], + ['ant@example.com', 'bee@example.com', 'cat@example.com']) |