summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbwarsaw2002-05-12 01:09:17 +0000
committerbwarsaw2002-05-12 01:09:17 +0000
commit674fe7931ec50f0684dede61c1357dc3d45621db (patch)
treead46af0bd250355bc6a4ff92fd623e3206dff7d6
parent8ffbae5ce83c396885c5c5a10b5d93e9ba1afe0b (diff)
downloadmailman-674fe7931ec50f0684dede61c1357dc3d45621db.tar.gz
mailman-674fe7931ec50f0684dede61c1357dc3d45621db.tar.zst
mailman-674fe7931ec50f0684dede61c1357dc3d45621db.zip
-rw-r--r--Mailman/Handlers/Sendmail.py18
1 files changed, 16 insertions, 2 deletions
diff --git a/Mailman/Handlers/Sendmail.py b/Mailman/Handlers/Sendmail.py
index 8940d5680..8bd88697f 100644
--- a/Mailman/Handlers/Sendmail.py
+++ b/Mailman/Handlers/Sendmail.py
@@ -14,7 +14,12 @@
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
-"""Deliver a message via `sendmail' drop-off.
+"""Deliver a message via command-line drop-off.
+
+WARNING WARNING WARNING: This module is provided for example purposes only.
+It should not be used in a production environment for reasons described
+below. Because of this, you must explicitly enable it with by editing the
+code. See the WARN section in the process() function.
This module delivers the message via the command line interface to the
sendmail program. It should work for sendmail clones like Postfix. It is
@@ -25,8 +30,13 @@ about 3k in size.
SECURITY WARNING: Because this module uses os.popen(), it goes through the
shell. This module does not scan the arguments for potential exploits and so
it should be considered unsafe for production use. For performance reasons,
-it's not recommended either -- use the SMTPDirect delivery module instead.
+it's not recommended either -- use the SMTPDirect delivery module instead,
+even if you're using the sendmail MTA.
+DUPLICATES WARNING: Using this module can cause duplicates to be delivered to
+your membership, depending on your MTA! E.g. It is known that if you're using
+the sendmail MTA, and if a message contains a single dot on a line by itself,
+your list members will receive many duplicates.
"""
import string
@@ -55,6 +65,10 @@ def process(mlist, msg, msgdata):
program.
"""
+ # WARN: If you've read the warnings above and /still/ insist on using this
+ # module, you must comment out the following line. I still recommend you
+ # don't do this!
+ assert 0, 'Use of the Sendmail.py delivery module is highly discouraged'
recips = msgdata.get('recips')
if not recips:
# Nobody to deliver to!