diff options
| author | Ruslan Mustakov | 2017-09-22 12:56:02 +0700 |
|---|---|---|
| committer | Ruslan Mustakov | 2017-09-25 16:19:21 +0700 |
| commit | 1a2311e3505765e37b736fe6bb46bb229e00701f (patch) | |
| tree | fd592573dbe7d95b89649eaa677bef54336c648e /drivers/windows | |
| parent | 14b4ad931f54c73aff9021a1314943278295e602 (diff) | |
| download | godot-1a2311e3505765e37b736fe6bb46bb229e00701f.tar.gz godot-1a2311e3505765e37b736fe6bb46bb229e00701f.tar.zst godot-1a2311e3505765e37b736fe6bb46bb229e00701f.zip | |
Extract logging logic
Previously logging logic was scattered over OS class implementations
with plenty of duplication. Major changes in this commit:
- Extracted logging logic into a separate Logger hierarchy. It allows
easy configuration of logging mechanism depending on compile-time or
run-time configuration.
- Implemented RotatedFileLogger which is usually used with StdLogger,
providing persistency of logs. It is often important to be able to
obtain logs of the game even in production to be able to understand
what happened prior to some problem. On mobile there previously was
no way to obtain the logs aside from having the device connected to
your machine.
- flush() is not performed in release mode for every logged line. It
is only performed for errors.
Diffstat (limited to 'drivers/windows')
| -rw-r--r-- | drivers/windows/dir_access_windows.cpp | 2 | ||||
| -rw-r--r-- | drivers/windows/file_access_windows.cpp | 6 | ||||
| -rw-r--r-- | drivers/windows/file_access_windows.h | 1 |
3 files changed, 8 insertions, 1 deletions
diff --git a/drivers/windows/dir_access_windows.cpp b/drivers/windows/dir_access_windows.cpp index 6d6a6027d..8d6e78dbe 100644 --- a/drivers/windows/dir_access_windows.cpp +++ b/drivers/windows/dir_access_windows.cpp @@ -162,10 +162,10 @@ Error DirAccessWindows::make_dir(String p_dir) { GLOBAL_LOCK_FUNCTION + p_dir = fix_path(p_dir); if (p_dir.is_rel_path()) p_dir = get_current_dir().plus_file(p_dir); - p_dir = fix_path(p_dir); p_dir = p_dir.replace("/", "\\"); bool success; diff --git a/drivers/windows/file_access_windows.cpp b/drivers/windows/file_access_windows.cpp index d128b5824..3b6e469c9 100644 --- a/drivers/windows/file_access_windows.cpp +++ b/drivers/windows/file_access_windows.cpp @@ -207,6 +207,12 @@ Error FileAccessWindows::get_error() const { return last_error; } +void FileAccessWindows::flush() { + + ERR_FAIL_COND(!f); + fflush(f); +} + void FileAccessWindows::store_8(uint8_t p_dest) { ERR_FAIL_COND(!f); diff --git a/drivers/windows/file_access_windows.h b/drivers/windows/file_access_windows.h index 15cbdca73..e5e7fd4a1 100644 --- a/drivers/windows/file_access_windows.h +++ b/drivers/windows/file_access_windows.h @@ -64,6 +64,7 @@ public: virtual Error get_error() const; ///< get last error + virtual void flush(); virtual void store_8(uint8_t p_dest); ///< store a byte virtual bool file_exists(const String &p_name); ///< return true if a file exists |