diff options
| author | Wilson E. Alvarez | 2018-03-27 21:14:52 -0400 |
|---|---|---|
| committer | Hein-Pieter van Braam | 2018-04-15 00:54:00 +0200 |
| commit | 8ebd4bb874d7eadf2d5133f7ffd34c82d7838086 (patch) | |
| tree | 0546fa67f5d1a9004df336281855a9a1338e0c84 | |
| parent | 63a88c69ace63de4a3024854e991c8ca896471e9 (diff) | |
| download | godot-8ebd4bb874d7eadf2d5133f7ffd34c82d7838086.tar.gz godot-8ebd4bb874d7eadf2d5133f7ffd34c82d7838086.tar.zst godot-8ebd4bb874d7eadf2d5133f7ffd34c82d7838086.zip | |
Move GodotSharp and MonoBuildTab member variables to initializer list
(cherry picked from commit 3f86fefb64cc8caeaeb1eb65471dfd18191eae85)
| -rw-r--r-- | modules/mono/editor/godotsharp_builds.cpp | 13 | ||||
| -rw-r--r-- | modules/mono/editor/mono_bottom_panel.cpp | 23 |
2 files changed, 15 insertions, 21 deletions
diff --git a/modules/mono/editor/godotsharp_builds.cpp b/modules/mono/editor/godotsharp_builds.cpp index ad07f043b..2f2b5768d 100644 --- a/modules/mono/editor/godotsharp_builds.cpp +++ b/modules/mono/editor/godotsharp_builds.cpp @@ -525,11 +525,10 @@ void GodotSharpBuilds::BuildProcess::start(bool p_blocking) { } } -GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) { - - build_info = p_build_info; - build_tab = NULL; - exit_callback = p_callback; - exited = true; - exit_code = -1; +GodotSharpBuilds::BuildProcess::BuildProcess(const MonoBuildInfo &p_build_info, GodotSharpBuild_ExitCallback p_callback) : + build_info(p_build_info), + build_tab(NULL), + exit_callback(p_callback), + exited(true), + exit_code(-1) { } diff --git a/modules/mono/editor/mono_bottom_panel.cpp b/modules/mono/editor/mono_bottom_panel.cpp index 32aec2a3b..f1cf0bcdf 100644 --- a/modules/mono/editor/mono_bottom_panel.cpp +++ b/modules/mono/editor/mono_bottom_panel.cpp @@ -437,21 +437,16 @@ void MonoBuildTab::_bind_methods() { ClassDB::bind_method("_issue_activated", &MonoBuildTab::_issue_activated); } -MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) { - - build_info = p_build_info; - logs_dir = p_logs_dir; - - build_exited = false; - - issues_list = memnew(ItemList); +MonoBuildTab::MonoBuildTab(const MonoBuildInfo &p_build_info, const String &p_logs_dir) : + build_info(p_build_info), + logs_dir(p_logs_dir), + build_exited(false), + issues_list(memnew(ItemList)), + error_count(0), + warning_count(0), + errors_visible(true), + warnings_visible(true) { issues_list->set_v_size_flags(SIZE_EXPAND_FILL); issues_list->connect("item_activated", this, "_issue_activated"); add_child(issues_list); - - error_count = 0; - warning_count = 0; - - errors_visible = true; - warnings_visible = true; } |
