From b244e5747258ad14e226a6f9df56ebc4be0f353b Mon Sep 17 00:00:00 2001 From: J08nY Date: Thu, 19 Jun 2025 15:44:41 +0200 Subject: Fix multiples_computed and addition_chain. They cannot be used with short-circuiting mults. --- test/sca/test_rpa.py | 10 ++++++++++ test/sca/test_zvp.py | 5 +++-- 2 files changed, 13 insertions(+), 2 deletions(-) (limited to 'test/sca') diff --git a/test/sca/test_rpa.py b/test/sca/test_rpa.py index 07757fd..8ba719c 100644 --- a/test/sca/test_rpa.py +++ b/test/sca/test_rpa.py @@ -82,6 +82,16 @@ def test_multiples(rpa_params): assert multiples == {1, 2, 4, 8, 16, 17} +def test_multiples_no_init(rpa_params): + multiples = multiples_computed( + 78699, rpa_params, LTRMultiplier, + lambda add, dbl, *args, **kwargs: LTRMultiplier( + add, dbl, None, False, AccumulationOrder.PeqPR, True, False + ), False, True + ) + assert multiples + + def test_multiples_bnaf(rpa_params): mult_partial = partial(BinaryNAFMultiplier, always=True, direction=ProcessingDirection.LTR) multiples = multiples_computed( diff --git a/test/sca/test_zvp.py b/test/sca/test_zvp.py index 496810b..6a06884 100644 --- a/test/sca/test_zvp.py +++ b/test/sca/test_zvp.py @@ -248,11 +248,12 @@ def test_addition_chain(secp128r1): secp128r1, LTRMultiplier, lambda add, dbl, *args, **kwargs: LTRMultiplier( - add, dbl, None, False, AccumulationOrder.PeqPR, True, True + add, dbl, None, False, AccumulationOrder.PeqPR, True, False ), ) assert res is not None - assert len(res) == 25 + # Plenty of operations on infty point, due to complete=True and no short_circuit + assert len(res) == 138 @pytest.mark.parametrize("k", [7, 25, 31]) -- cgit v1.2.3-70-g09d2