1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
|
# Copyright (C) 2014-2017 by the Free Software Foundation, Inc.
#
# This file is part of GNU Mailman.
#
# GNU Mailman is free software: you can redistribute it and/or modify it under
# the terms of the GNU General Public License as published by the Free
# Software Foundation, either version 3 of the License, or (at your option)
# any later version.
#
# GNU Mailman is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
# more details.
#
# You should have received a copy of the GNU General Public License along with
# GNU Mailman. If not, see <http://www.gnu.org/licenses/>.
"""Test the `member-moderation` and `nonmember-moderation` rules."""
import unittest
from mailman.app.lifecycle import create_list
from mailman.interfaces.action import Action
from mailman.interfaces.bans import IBanManager
from mailman.interfaces.member import MemberRole
from mailman.interfaces.usermanager import IUserManager
from mailman.rules import moderation
from mailman.testing.helpers import (
set_preferred, specialized_message_from_string as mfs)
from mailman.testing.layers import ConfigLayer
from zope.component import getUtility
class TestModeration(unittest.TestCase):
"""Test the approved handler."""
layer = ConfigLayer
def setUp(self):
self._mlist = create_list('test@example.com')
def test_member_and_nonmember(self):
user_manager = getUtility(IUserManager)
anne = user_manager.create_address('anne@example.com')
user_manager.create_address('bill@example.com')
self._mlist.subscribe(anne, MemberRole.member)
rule = moderation.NonmemberModeration()
msg = mfs("""\
From: anne@example.com
Sender: bill@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
# Both Anne and Bill are in the message's senders list.
self.assertIn('anne@example.com', msg.senders)
self.assertIn('bill@example.com', msg.senders)
# The NonmemberModeration rule should *not* hit, because even though
# Bill is in the list of senders he is not a member of the mailing
# list. Anne is also in the list of senders and she *is* a member, so
# she takes precedence.
result = rule.check(self._mlist, msg, {})
self.assertFalse(result, 'NonmemberModeration rule should not hit')
# After the rule runs, Bill becomes a non-member.
bill_member = self._mlist.nonmembers.get_member('bill@example.com')
self.assertIsNotNone(bill_member)
# Bill is not a member.
bill_member = self._mlist.members.get_member('bill@example.com')
self.assertIsNone(bill_member)
def test_moderation_reason(self):
# When a message is moderated, a reason is added to the metadata.
user_manager = getUtility(IUserManager)
anne = user_manager.create_address('anne@example.com')
msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
# Anne is in the message's senders list.
self.assertIn('anne@example.com', msg.senders)
# Now run the rule.
rule = moderation.NonmemberModeration()
msgdata = {}
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result, 'NonmemberModeration rule should hit')
# The reason for moderation should be in the msgdata.
reasons = msgdata['moderation_reasons']
self.assertEqual(reasons, ['The message is not from a list member'])
# Now make Anne a moderated member...
anne_member = self._mlist.subscribe(anne, MemberRole.member)
anne_member.moderation_action = Action.hold
# ...and run the rule again.
rule = moderation.MemberModeration()
msgdata = {}
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result, 'MemberModeration rule should hit')
# The reason for moderation should be in the msgdata.
reasons = msgdata['moderation_reasons']
self.assertEqual(
reasons, ['The message comes from a moderated member'])
def test_these_nonmembers(self):
# Test the legacy *_these_nonmembers attributes.
user_manager = getUtility(IUserManager)
actions = {
'anne@example.com': 'accept',
'bill@example.com': 'hold',
'chris@example.com': 'reject',
'dana@example.com': 'discard',
'^anne-.*@example.com': 'accept',
'^bill-.*@example.com': 'hold',
'^chris-.*@example.com': 'reject',
'^dana-.*@example.com': 'discard',
}
rule = moderation.NonmemberModeration()
user_manager = getUtility(IUserManager)
for address, action_name in actions.items():
setattr(self._mlist,
'{}_these_nonmembers'.format(action_name),
[address])
if address.startswith('^'):
# It's a pattern, craft a proper address.
address = address[1:].replace('.*', 'something')
user_manager.create_address(address)
msg = mfs("""\
From: {}
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""".format(address))
msgdata = {}
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result, 'NonmemberModeration rule should hit')
self.assertIn('member_moderation_action', msgdata)
self.assertEqual(
msgdata['member_moderation_action'], action_name,
'Wrong action for {}: {}'.format(address, action_name))
def test_nonmember_fallback_to_list_defaults(self):
# https://gitlab.com/mailman/mailman/issues/189
self._mlist.default_nonmember_action = Action.hold
user_manager = getUtility(IUserManager)
user_manager.create_address('anne@example.com')
rule = moderation.NonmemberModeration()
msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
# First, the message should get held.
msgdata = {}
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result)
self.assertEqual(msgdata['member_moderation_action'], 'hold')
# As a side-effect, Anne has been added as a nonmember with a
# moderation action that falls back to the list's default.
anne = self._mlist.nonmembers.get_member('anne@example.com')
self.assertIsNone(anne.moderation_action)
# Then the list's default nonmember action is changed.
self._mlist.default_nonmember_action = Action.discard
msg.replace_header('Message-ID', '<bee>')
# This time, the message should be discarded.
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result)
self.assertEqual(msgdata.get('member_moderation_action'), 'discard')
def test_member_fallback_to_list_defaults(self):
# https://gitlab.com/mailman/mailman/issues/189
self._mlist.default_member_action = Action.accept
user_manager = getUtility(IUserManager)
anne = user_manager.create_address('anne@example.com')
member = self._mlist.subscribe(anne, MemberRole.member)
# Anne's moderation rule falls back to the list default.
self.assertIsNone(member.moderation_action)
rule = moderation.MemberModeration()
msg = mfs("""\
From: anne@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
# First, the message gets accepted.
msgdata = {}
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result)
self.assertEqual(msgdata.get('member_moderation_action'), 'accept')
# Then the list's default member action is changed.
self._mlist.default_member_action = Action.hold
msg.replace_header('Message-ID', '<bee>')
# This time, the message is held.
result = rule.check(self._mlist, msg, msgdata)
self.assertTrue(result)
self.assertEqual(msgdata.get('member_moderation_action'), 'hold')
def test_linked_address_nonmembermoderation_misses(self):
# Anne subscribes to a mailing list as a user with her preferred
# address. She also has a secondary linked address, and she uses this
# to post to the mailing list. The NonmemberModeration rule misses
# because Anne is not a nonmember.
user_manager = getUtility(IUserManager)
anne = user_manager.create_user('anne@example.com')
set_preferred(anne)
self._mlist.subscribe(anne, MemberRole.member)
anne.link(user_manager.create_address('anne.person@example.com'))
rule = moderation.NonmemberModeration()
msg = mfs("""\
From: anne.person@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
result = rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_linked_address_membermoderation_hits(self):
# Anne subscribes to a mailing list as a user with her preferred
# address. She also has a secondary linked address, and she uses this
# to post to the mailing list. The MemberModeration rule hits because
# Anne is a member.
self._mlist.default_member_action = Action.accept
user_manager = getUtility(IUserManager)
anne = user_manager.create_user('anne@example.com')
set_preferred(anne)
self._mlist.subscribe(anne, MemberRole.member)
anne.link(user_manager.create_address('anne.person@example.com'))
rule = moderation.MemberModeration()
msg = mfs("""\
From: anne.person@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
result = rule.check(self._mlist, msg, {})
self.assertTrue(result)
def test_banned_address_linked_to_user(self):
# Anne is subscribed to a mailing list as a user with her preferred
# address. She also has a secondary address which is banned and which
# she uses to post to the mailing list. Both the MemberModeration and
# NonmemberModeration rules miss because the posting address is
# banned.
user_manager = getUtility(IUserManager)
anne = user_manager.create_user('anne@example.com')
set_preferred(anne)
self._mlist.subscribe(anne, MemberRole.member)
anne.link(user_manager.create_address('anne.person@example.com'))
IBanManager(self._mlist).ban('anne.person@example.com')
msg = mfs("""\
From: anne.person@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
rule = moderation.MemberModeration()
result = rule.check(self._mlist, msg, {})
self.assertFalse(result)
rule = moderation.NonmemberModeration()
result = rule.check(self._mlist, msg, {})
self.assertFalse(result)
def test_banned_sender_among_multiple_senders(self):
# Two addresses are created, one of which is banned. Even though the
# The Nonmember moderation rule misses if any of the banned addresses
# appear in the 'senders' headers of the message.
user_manager = getUtility(IUserManager)
user_manager.create_address('anne@example.com')
user_manager.create_address('bart@example.com')
IBanManager(self._mlist).ban('bart@example.com')
rule = moderation.NonmemberModeration()
msg = mfs("""\
From: anne@example.com
Sender: bart@example.com
To: test@example.com
Subject: A test message
Message-ID: <ant>
MIME-Version: 1.0
A message body.
""")
result = rule.check(self._mlist, msg, {})
self.assertFalse(result)
|
