From ae0042a90220119414f61aeb20c6b58bfacb8af2 Mon Sep 17 00:00:00 2001
From: Barry Warsaw
Date: Tue, 29 Aug 2017 14:07:54 +0000
Subject: PR288 vetted

---
 src/mailman/bin/mailman.py | 39 +++++++++++++++++++++++----------------
 1 file changed, 23 insertions(+), 16 deletions(-)

(limited to 'src/mailman/bin/mailman.py')

diff --git a/src/mailman/bin/mailman.py b/src/mailman/bin/mailman.py
index 6b8cb26da..0ea29edbb 100644
--- a/src/mailman/bin/mailman.py
+++ b/src/mailman/bin/mailman.py
@@ -16,7 +16,6 @@
 # GNU Mailman.  If not, see <http://www.gnu.org/licenses/>.
 
 """The 'mailman' command dispatcher."""
-
 import click
 
 from contextlib import ExitStack
@@ -35,17 +34,21 @@ class Subcommands(click.MultiCommand):
     def __init__(self, *args, **kws):
         super().__init__(*args, **kws)
         self._commands = {}
-        # Look at all modules in the mailman.bin package and if they are
-        # prepared to add a subcommand, let them do so.  I'm still undecided as
-        # to whether this should be pluggable or not.  If so, then we'll
-        # probably have to partially parse the arguments now, then initialize
-        # the system, then find the plugins.  Punt on this for now.
-        add_components('mailman.commands', ICLISubCommand, self._commands)
+        self._loaded = False
+
+    def _load(self):
+        # Load commands lazily as commands in plugins can only be found after
+        # the configuration file is loaded.
+        if not self._loaded:
+            add_components('commands', ICLISubCommand, self._commands)
+            self._loaded = True
 
-    def list_commands(self, ctx):
-        return sorted(self._commands)               # pragma: nocover
+    def list_commands(self, ctx):                    # pragma: nocover
+        self._load()
+        return sorted(self._commands)
 
     def get_command(self, ctx, name):
+        self._load()
         try:
             return self._commands[name].command
         except KeyError as error:
@@ -85,10 +88,11 @@ class Subcommands(click.MultiCommand):
         super().format_commands(ctx, formatter)
 
 
-@click.group(
-    cls=Subcommands,
-    context_settings=dict(help_option_names=['-h', '--help']))
-@click.pass_context
+def initialize_config(ctx, param, value):
+    if not ctx.resilient_parsing:
+        initialize(value)
+
+
 @click.option(
     '-C', '--config', 'config_file',
     envvar='MAILMAN_CONFIG_FILE',
@@ -96,7 +100,12 @@ class Subcommands(click.MultiCommand):
     help=_("""\
     Configuration file to use.  If not given, the environment variable
     MAILMAN_CONFIG_FILE is consulted and used if set.  If neither are given, a
-    default configuration file is loaded."""))
+    default configuration file is loaded."""),
+    is_eager=True, callback=initialize_config)
+@click.group(
+    cls=Subcommands,
+    context_settings=dict(help_option_names=['-h', '--help']))
+@click.pass_context
 @click.version_option(MAILMAN_VERSION_FULL, message='%(version)s')
 @public
 def main(ctx, config_file):
@@ -106,6 +115,4 @@ def main(ctx, config_file):
     Copyright 1998-2017 by the Free Software Foundation, Inc.
     http://www.list.org
     """
-    # Initialize the system.  Honor the -C flag if given.
-    initialize(config_file)
     # click handles dispatching to the subcommand via the Subcommands class.
-- 
cgit v1.2.3-70-g09d2