The most likely cause is that Mailman was "); - printf("configured and installed incorrectly. Please "); - printf("read the INSTALL instructions again, paying close "); - printf("attention to the --with-cgi-gid configure "); - printf("option. This entry is being stored in your syslog:"); - printf("\n
\n");
- printf(log_entry);
- printf("\n");
- }
- else
- fprintf(stderr, "%s\n", log_entry);
+ /* If we're running as a CGI script, we also want to write the log
+ * file out as HTML, so the admin who is probably trying to debug his
+ * installation will have a better clue as to what's going on.
+ *
+ * Otherwise, print to stderr a short message, hopefully returned to
+ * the sender by the MTA.
+ */
+ if (running_as_cgi) {
+ printf("Content-type: text/html\n\n");
+ printf("\n");
+ printf("\n");
+ printf(log_entry);
+ printf("\n");
+ }
+ else
+ fprintf(stderr, "%s\n", log_entry);
#endif /* HELPFUL */
- exit(exitcode);
+ exit(exitcode);
}
@@ -118,15 +116,42 @@ fatal(const char* ident, int exitcode, char* format, ...)
/* Is the parent process allowed to call us?
*/
void
-check_caller(const char* ident, GID_T parentgid)
+check_caller(const char* ident, const char* parentgroup)
{
- GID_T mygid = getgid();
- if (parentgid != mygid) {
- fatal(ident, GID_MISMATCH,
- "Failure to exec script. WANTED gid %ld, GOT gid %ld. "
- "(Reconfigure to take %ld?)",
- parentgid, mygid, mygid);
+ GID_T mygid = getgid();
+ struct group *mygroup = getgrgid(mygid);
+ char* option;
+ char* server;
+ char* wrapper;
+
+ if (running_as_cgi) {
+ option = "--with-cgi-gid";
+ server = "web";
+ wrapper = "CGI";
}
+ else {
+ option = "--with-mail-gid";
+ server = "mail";
+ wrapper = "mail";
+ }
+
+ if (!mygroup)
+ fatal(ident, GROUP_NAME_NOT_FOUND,
+ "Failure to find group name %s. Try adding this group\n"
+ "to your system, or re-run configure, providing an\n"
+ "existing group name with the command line option %s.",
+ parentgroup, option);
+
+ if (strcmp(parentgroup, mygroup->gr_name))
+ fatal(ident, GROUP_MISMATCH,
+ "Group mismatch error. Mailman expected the %s\n"
+ "wrapper script to be executed as group \"%s\", but\n"
+ "the system's %s server executed the %s script as\n"
+ "group \"%s\". Try tweaking the %s server to run the\n"
+ "script as group \"%s\", or re-run configure, \n"
+ "providing the command line option `%s=%s'.",
+ wrapper, parentgroup, server, wrapper, mygroup->gr_name,
+ server, parentgroup, option, mygroup->gr_name);
}
@@ -142,12 +167,12 @@ check_caller(const char* ident, GID_T parentgid)
* them right (which it should because Python strings have no hard limits).
*/
static char* killenvars[] = {
- "PYTHONPATH=",
- "PYTHONHOME=",
- "PATH=",
- NULL
+ "PYTHONPATH=",
+ "PYTHONHOME=",
+ "PATH=",
+ NULL
};
-
+
/* Run a Python script out of the script directory
@@ -161,27 +186,27 @@ static char* killenvars[] = {
int
run_script(const char* script, int argc, char** argv, char** env)
{
- const char envstr[] = "PYTHONPATH=";
- const int envlen = strlen(envstr);
-
- int envcnt = 0;
- int i, j, status;
- char** newenv;
- char** newargv;
-
- /* We need to set the real gid to the effective gid because there are
- * some Linux systems which do not preserve the effective gid across
- * popen() calls. This breaks mail delivery unless the ~mailman/data
- * directory is chown'd to the uid that runs mail programs, and that
- * isn't a viable alternative.
- */
+ const char envstr[] = "PYTHONPATH=";
+ const int envlen = strlen(envstr);
+
+ int envcnt = 0;
+ int i, j, status;
+ char** newenv;
+ char** newargv;
+
+ /* We need to set the real gid to the effective gid because there are
+ * some Linux systems which do not preserve the effective gid across
+ * popen() calls. This breaks mail delivery unless the ~mailman/data
+ * directory is chown'd to the uid that runs mail programs, and that
+ * isn't a viable alternative.
+ */
#ifdef HAVE_SETREGID
- status = setregid(getegid(), -1);
- if (status)
- fatal(logident, SETREGID_FAILURE, "%s", strerror(errno));
+ status = setregid(getegid(), -1);
+ if (status)
+ fatal(logident, SETREGID_FAILURE, "%s", strerror(errno));
#endif /* HAVE_SETREGID */
- /* We want to tightly control how the CGI scripts get executed.
+ /* We want to tightly control how the CGI scripts get executed.
* For portability and security, the path to the Python executable
* is hard-coded into this C wrapper, rather than encoded in the #!
* line of the script that gets executed. So we invoke those
@@ -191,78 +216,78 @@ run_script(const char* script, int argc, char** argv, char** env)
* We also need to hack on the PYTHONPATH environment variable so
* that the path to the installed Mailman modules will show up
* first on sys.path.
- *
+ *
*/
- for (envcnt = 0; env[envcnt]; envcnt++)
- ;
-
- /* okay to be a little too big */
- newenv = (char**)malloc(sizeof(char*) * (envcnt + 2));
-
- /* filter out any troublesome environment variables */
- for (i = 0, j = 0; i < envcnt; i++) {
- char** k = &killenvars[0];
- int keep = 1;
- while (*k) {
- if (!strncmp(*k, env[i], strlen(*k))) {
- keep = 0;
- break;
- }
- *k++;
- }
- if (keep)
- newenv[j++] = env[i];
- }
-
- /* Tack on our own version of PYTHONPATH, which should contain only
- * the path to the Mailman package modules.
- *
- * $(PREFIX)/modules
- */
- newenv[j] = (char*)malloc(sizeof(char) * (
- strlen(envstr) +
- strlen(moduledir) +
- 1));
- strcpy(newenv[j], envstr);
- strcat(newenv[j], moduledir);
- j++;
-
- newenv[j] = NULL;
-
- /* Now put together argv. This will contain first the absolute path
- * to the Python executable, then the -S option (to speed executable
- * start times), then the absolute path to the script, then any
- * additional args passed in argv above.
- */
- newargv = (char**)malloc(sizeof(char*) * (argc + 3));
- j = 0;
- newargv[j++] = python;
- newargv[j++] = "-S";
- newargv[j] = (char*)malloc(sizeof(char) * (
- strlen(scriptdir) +
- strlen(script) +
- 1));
- strcpy(newargv[j], scriptdir);
- strcat(newargv[j], script);
-
- /* now tack on all the rest of the arguments. we can skip argv's
- * first two arguments because, for cgi-wrapper there is only argv[0].
- * For mail-wrapper, argv[1] is the mail command (e.g. post,
- * mailowner, or mailcmd) and argv[2] is the listname. The mail
- * command to execute gets passed in as this function's `script'
- * parameter and becomes the argument to the python interpreter. The
- * list name therefore should become argv[2] to this process.
- *
- * TBD: have to make sure this works with alias-wrapper.
- */
- for (i=2, j++; i < argc; i++)
- newargv[j++] = argv[i];
+ for (envcnt = 0; env[envcnt]; envcnt++)
+ ;
+
+ /* okay to be a little too big */
+ newenv = (char**)malloc(sizeof(char*) * (envcnt + 2));
+
+ /* filter out any troublesome environment variables */
+ for (i = 0, j = 0; i < envcnt; i++) {
+ char** k = &killenvars[0];
+ int keep = 1;
+ while (*k) {
+ if (!strncmp(*k, env[i], strlen(*k))) {
+ keep = 0;
+ break;
+ }
+ *k++;
+ }
+ if (keep)
+ newenv[j++] = env[i];
+ }
+
+ /* Tack on our own version of PYTHONPATH, which should contain only
+ * the path to the Mailman package modules.
+ *
+ * $(PREFIX)/modules
+ */
+ newenv[j] = (char*)malloc(sizeof(char) * (
+ strlen(envstr) +
+ strlen(moduledir) +
+ 1));
+ strcpy(newenv[j], envstr);
+ strcat(newenv[j], moduledir);
+ j++;
+
+ newenv[j] = NULL;
+
+ /* Now put together argv. This will contain first the absolute path
+ * to the Python executable, then the -S option (to speed executable
+ * start times), then the absolute path to the script, then any
+ * additional args passed in argv above.
+ */
+ newargv = (char**)malloc(sizeof(char*) * (argc + 3));
+ j = 0;
+ newargv[j++] = python;
+ newargv[j++] = "-S";
+ newargv[j] = (char*)malloc(sizeof(char) * (
+ strlen(scriptdir) +
+ strlen(script) +
+ 1));
+ strcpy(newargv[j], scriptdir);
+ strcat(newargv[j], script);
+
+ /* now tack on all the rest of the arguments. we can skip argv's
+ * first two arguments because, for cgi-wrapper there is only argv[0].
+ * For mail-wrapper, argv[1] is the mail command (e.g. post,
+ * mailowner, or mailcmd) and argv[2] is the listname. The mail
+ * command to execute gets passed in as this function's `script'
+ * parameter and becomes the argument to the python interpreter. The
+ * list name therefore should become argv[2] to this process.
+ *
+ * TBD: have to make sure this works with alias-wrapper.
+ */
+ for (i=2, j++; i < argc; i++)
+ newargv[j++] = argv[i];
- newargv[j] = NULL;
+ newargv[j] = NULL;
- /* return always means failure */
- (void)execve(python, &newargv[0], &newenv[0]);
- return EXECVE_FAILURE;
+ /* return always means failure */
+ (void)execve(python, &newargv[0], &newenv[0]);
+ return EXECVE_FAILURE;
}
--
cgit v1.2.3-70-g09d2