From 460bd607cd4e66c3a33c884650eeb3ddb71590a8 Mon Sep 17 00:00:00 2001 From: bwarsaw Date: Fri, 2 Jul 1999 23:58:28 +0000 Subject: fatal(): Use vsnprintf() to avoid potential buffer overflow vulnerability (PR#72) --- src/common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common.c b/src/common.c index cddefb915..0e7aac955 100644 --- a/src/common.c +++ b/src/common.c @@ -55,14 +55,16 @@ char* strerror(int errno) /* Report on errors and exit */ +#define BUFSIZE 1024 + void fatal(const char* ident, int exitcode, const char* format, ...) { - char log_entry[1024]; + char log_entry[BUFSIZE]; va_list arg_ptr; va_start(arg_ptr, format); - vsprintf(log_entry, format, arg_ptr); + vsnprintf(log_entry, BUFSIZE, format, arg_ptr); va_end(arg_ptr); #ifdef HAVE_SYSLOG -- cgit v1.3.1