summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/mailman/model/requests.py4
-rw-r--r--src/mailman/rest/post_moderation.py2
2 files changed, 2 insertions, 4 deletions
diff --git a/src/mailman/model/requests.py b/src/mailman/model/requests.py
index 39e43bc40..69d8cf199 100644
--- a/src/mailman/model/requests.py
+++ b/src/mailman/model/requests.py
@@ -87,10 +87,8 @@ class ListRequests:
@dbconnection
def of_type(self, store, request_type):
- results = store.query(_Request).filter_by(
+ return store.query(_Request).filter_by(
mailing_list=self.mailing_list, request_type=request_type)
- for request in results:
- yield request
@dbconnection
def hold_request(self, store, request_type, key, data=None):
diff --git a/src/mailman/rest/post_moderation.py b/src/mailman/rest/post_moderation.py
index efb13e58a..ca3e228ba 100644
--- a/src/mailman/rest/post_moderation.py
+++ b/src/mailman/rest/post_moderation.py
@@ -148,7 +148,7 @@ class HeldMessages(_HeldMessageBase, CollectionMixin):
def _get_collection(self, request):
requests = IListRequests(self._mlist)
- return list(requests.of_type(RequestType.held_message))
+ return requests.of_type(RequestType.held_message)
def on_get(self, request, response):
"""/lists/listname/held"""