* List styles are supported through the REST API. Get the list of available

   styles (by name) via `.../lists/styles`.  Create a list in a specific style
   by using POST data `style_name=<style>`.  (LP: #975692)

 * The default list style is renamed to `legacy-default` and a new
   `legacy-announce` style is added.  This is similar to the `legacy-default`
   except set up for announce-only lists.

 * The following columns were unused and have been removed:

   - `mailinglist.new_member_options`
   - `mailinglist.send_reminders`
   - `mailinglist.subscribe_policy`
   - `mailinglist.unsubscribe_policy`
   - `mailinglist.subscribe_auto_approval`
   - `mailinglist.private_roster`
   - `mailinglist.admin_member_chunksize`

Also:
 * List styles no longer have a priority, nor is there any style matching any
   more.  Now, exactly one named style (either explicitly through the
   `create_list()` function, or by default from the configuration file) is
   applied to a list at list creation time.
 * The huge old DefaultStyle is now decomposed into smaller units.  An
   announce-like style is added.
 * `find_components()` and `scan_module()` moved from `app/finder.py` to
   `utilities/modules.py`.
 * Lots of doctest rewriting for better documentation.  Bad-path tests moved
   to unittests.
 * `create_list()` now takes an optional `style_name` parameter.  If not
   given, `[styles]default` is used.
 * `create_list()` doesn't set the `personalize` or `display_name` attributes
   any more.  These are already set in styles.
 * Removed an unnecessary `tearDown()`.
 * Added some improvements on displaying lists in JSON responses.

1 files changed, 53 insertions, 0 deletions

diff --git a/src/mailman/utilities/modules.py b/src/mailman/utilities/modules.py
index d8b788054..4ba549f99 100644
--- a/src/mailman/utilities/modules.py
+++ b/src/mailman/utilities/modules.py
@@ -22,12 +22,17 @@ from __future__ import absolute_import, unicode_literals
 __metaclass__ = type
 __all__ = [
     'call_name',
+    'find_components',
     'find_name',
+    'scan_module',
     ]
 
 
+import os
 import sys
 
+from pkg_resources import resource_listdir
+
 
 
 def find_name(dotted_name):
@@ -43,6 +48,7 @@ def find_name(dotted_name):
     return getattr(sys.modules[package_path], object_name)
 
 
+
 def call_name(dotted_name, *args, **kws):
     """Imports and calls the named object in package space.
 
@@ -57,3 +63,50 @@ def call_name(dotted_name, *args, **kws):
     """
     named_callable = find_name(dotted_name)
     return named_callable(*args, **kws)
+
+
+
+def scan_module(module, interface):
+    """Return all the items in a module that conform to an interface.
+
+    :param module: A module object.  The module's `__all__` will be scanned.
+    :type module: module
+    :param interface: The interface that returned objects must conform to.
+    :type interface: `Interface`
+    :return: The sequence of matching components.
+    :rtype: objects implementing `interface`
+    """
+    missing = object()
+    for name in module.__all__:
+        component = getattr(module, name, missing)
+        assert component is not missing, (
+            '%s has bad __all__: %s' % (module, name))
+        if interface.implementedBy(component):
+            yield component
+
+
+
+def find_components(package, interface):
+    """Find components which conform to a given interface.
+
+    Search all the modules in a given package, returning an iterator over all
+    objects found that conform to the given interface.
+
+    :param package: The package path to search.
+    :type package: string
+    :param interface: The interface that returned objects must conform to.
+    :type interface: `Interface`
+    :return: The sequence of matching components.
+    :rtype: objects implementing `interface`
+    """
+    for filename in resource_listdir(package, ''):
+        basename, extension = os.path.splitext(filename)
+        if extension != '.py':
+            continue
+        module_name = '{0}.{1}'.format(package, basename)
+        __import__(module_name, fromlist='*')
+        module = sys.modules[module_name]
+        if not hasattr(module, '__all__'):
+            continue
+        for component in scan_module(module, interface):
+            yield component