diff options
| author | Barry Warsaw | 2016-11-28 17:19:18 -0500 |
|---|---|---|
| committer | Barry Warsaw | 2016-11-28 20:31:09 -0500 |
| commit | da0789ceedbeddcae6b47545c115f5e659de019d (patch) | |
| tree | 1d7cbea5e0895c935f9905c852cd332a000b4e8a /src/mailman/rules | |
| parent | 8ee8a7d2cb598138aeadfebe8eb5cc3f8fb2d88a (diff) | |
| download | mailman-da0789ceedbeddcae6b47545c115f5e659de019d.tar.gz mailman-da0789ceedbeddcae6b47545c115f5e659de019d.tar.zst mailman-da0789ceedbeddcae6b47545c115f5e659de019d.zip | |
Diffstat (limited to 'src/mailman/rules')
| -rw-r--r-- | src/mailman/rules/no_subject.py | 2 | ||||
| -rw-r--r-- | src/mailman/rules/suspicious.py | 2 | ||||
| -rw-r--r-- | src/mailman/rules/tests/test_no_subject.py | 9 | ||||
| -rw-r--r-- | src/mailman/rules/tests/test_suspicious.py | 7 |
4 files changed, 8 insertions, 12 deletions
diff --git a/src/mailman/rules/no_subject.py b/src/mailman/rules/no_subject.py index e6a3be6ed..ed020b81e 100644 --- a/src/mailman/rules/no_subject.py +++ b/src/mailman/rules/no_subject.py @@ -34,7 +34,7 @@ class NoSubject: def check(self, mlist, msg, msgdata): """See `IRule`.""" - # Convert the header value to string because it may be an + # Convert the header value to a str because it may be an # email.header.Header instance. subject = str(msg.get('subject', '')).strip() return subject == '' diff --git a/src/mailman/rules/suspicious.py b/src/mailman/rules/suspicious.py index acb17334a..679605fd6 100644 --- a/src/mailman/rules/suspicious.py +++ b/src/mailman/rules/suspicious.py @@ -87,7 +87,7 @@ def has_matching_bounce_header(mlist, msg): """ for header, cre, line in _parse_matching_header_opt(mlist): for value in msg.get_all(header, []): - # Convert the header value to string because it may be an + # Convert the header value to a str because it may be an # email.header.Header instance. if cre.search(str(value)): return True diff --git a/src/mailman/rules/tests/test_no_subject.py b/src/mailman/rules/tests/test_no_subject.py index efe942af6..0155e25ee 100644 --- a/src/mailman/rules/tests/test_no_subject.py +++ b/src/mailman/rules/tests/test_no_subject.py @@ -1,4 +1,4 @@ -# Copyright (C) 2015 by the Free Software Foundation, Inc. +# Copyright (C) 2016 by the Free Software Foundation, Inc. # # This file is part of GNU Mailman. # @@ -17,7 +17,6 @@ """Test the `no_subject` header rule.""" - import unittest from email.header import Header @@ -37,15 +36,13 @@ class TestNoSubject(unittest.TestCase): self._rule = no_subject.NoSubject() def test_header_instance_empty(self): - # Check the case where the subject is a Header instance msg = Message() - msg["Subject"] = Header("") + msg['Subject'] = Header('') result = self._rule.check(self._mlist, msg, {}) self.assertTrue(result) def test_header_instance_not_empty(self): - # Check the case where the subject is a Header instance msg = Message() - msg["Subject"] = Header("Test subject") + msg['Subject'] = Header('Test subject') result = self._rule.check(self._mlist, msg, {}) self.assertFalse(result) diff --git a/src/mailman/rules/tests/test_suspicious.py b/src/mailman/rules/tests/test_suspicious.py index e1649928c..441fb0b48 100644 --- a/src/mailman/rules/tests/test_suspicious.py +++ b/src/mailman/rules/tests/test_suspicious.py @@ -1,4 +1,4 @@ -# Copyright (C) 2015 by the Free Software Foundation, Inc. +# Copyright (C) 2016 by the Free Software Foundation, Inc. # # This file is part of GNU Mailman. # @@ -28,7 +28,7 @@ from mailman.testing.layers import ConfigLayer class TestSuspicious(unittest.TestCase): - """Test the suspicous rule.""" + """Test the suspicious rule.""" layer = ConfigLayer @@ -37,9 +37,8 @@ class TestSuspicious(unittest.TestCase): self._rule = suspicious.SuspiciousHeader() def test_header_instance(self): - # Check the case where the subject is a Header instance msg = Message() - msg["From"] = Header("user@example.com") + msg['From'] = Header('user@example.com') self._mlist.bounce_matching_headers = 'from: spam@example.com' result = self._rule.check(self._mlist, msg, {}) self.assertFalse(result) |
