plugin

1 files changed, 153 insertions, 0 deletions

diff --git a/src/mailman/database/tests/test_migrations.py b/src/mailman/database/tests/test_migrations.py
index ce1bc101b..104487350 100644
--- a/src/mailman/database/tests/test_migrations.py
+++ b/src/mailman/database/tests/test_migrations.py
@@ -18,6 +18,7 @@
 """Test database schema migrations with Alembic"""
 
 import os
+import json
 import unittest
 import sqlalchemy as sa
 import alembic.command
@@ -31,10 +32,13 @@ from mailman.database.transaction import transaction
 from mailman.database.types import Enum, SAUnicode
 from mailman.interfaces.action import Action
 from mailman.interfaces.cache import ICacheManager
+from mailman.interfaces.mailinglist import SubscriptionPolicy
 from mailman.interfaces.member import MemberRole
 from mailman.interfaces.template import ITemplateManager
 from mailman.interfaces.usermanager import IUserManager
 from mailman.testing.layers import ConfigLayer
+from mailman.workflows.subscription import ModerationSubscriptionPolicy
+from mailman.workflows.unsubscription import OpenUnsubscriptionPolicy
 from warnings import catch_warnings, simplefilter
 from zope.component import getUtility
 
@@ -495,3 +499,152 @@ class TestMigrations(unittest.TestCase):
         self.assertEqual(
             len(list(config.db.store.execute(mlist_table.select()))),
             0)
+
+    def test_7c5b39d1ecc4_workflow_steps_upgrade(self):
+        old_state_table = sa.sql.table(
+                'workflowstate',
+                sa.sql.column('token', SAUnicode),
+                sa.sql.column('step', SAUnicode),
+                sa.sql.column('data', SAUnicode)
+                )
+        new_state_table = sa.sql.table(
+                'workflowstate',
+                sa.sql.column('token', SAUnicode),
+                sa.sql.column('steps', SAUnicode),
+                sa.sql.column('data', SAUnicode)
+                )
+        with transaction():
+            # Start at the previous revision.
+            alembic.command.downgrade(alembic_cfg, '4bd95c99b2e7')
+            config.db.store.execute(old_state_table.insert().values([
+                dict(token='12345',
+                     step='some_step',
+                     data='whatever data'),
+                dict(token='6789',
+                     step=None,
+                     data='other data')
+                ]))
+
+        # Now upgrade.
+        alembic.command.upgrade(alembic_cfg, '7c5b39d1ecc4')
+
+        token, steps, data = config.db.store.execute(
+                new_state_table.select().where(
+                        new_state_table.c.token == '12345'
+                        )).fetchone()
+        self.assertEqual(token, '12345')
+        self.assertEqual(steps, json.dumps(['some_step']))
+        self.assertEqual(data, 'whatever data')
+
+        token, steps, data = config.db.store.execute(
+                new_state_table.select().where(
+                        new_state_table.c.token == '6789'
+                        )).fetchone()
+        self.assertEqual(token, '6789')
+        self.assertEqual(steps, json.dumps([]))
+        self.assertEqual(data, 'other data')
+
+    def test_7c5b39d1ecc4_workflow_steps_downgrade(self):
+        old_state_table = sa.sql.table(
+                'workflowstate',
+                sa.sql.column('token', SAUnicode),
+                sa.sql.column('step', SAUnicode),
+                sa.sql.column('data', SAUnicode)
+                )
+        new_state_table = sa.sql.table(
+                'workflowstate',
+                sa.sql.column('token', SAUnicode),
+                sa.sql.column('steps', SAUnicode),
+                sa.sql.column('data', SAUnicode)
+                )
+        with transaction():
+            # Start at the revision.
+            alembic.command.downgrade(alembic_cfg, '7c5b39d1ecc4')
+            config.db.store.execute(new_state_table.insert().values([
+                dict(token='12345',
+                     steps=json.dumps(['next_step', 'some_step']),
+                     data='whatever data'),
+                dict(token='6789',
+                     steps=json.dumps(['only_step']),
+                     data='other data'),
+                dict(token='abcde',
+                     steps=json.dumps([]),
+                     data='another data')
+                ]))
+        # Now downgrade.
+        alembic.command.downgrade(alembic_cfg, '4bd95c99b2e7')
+
+        token, step, data = config.db.store.execute(
+                old_state_table.select().where(
+                        old_state_table.c.token == '12345'
+                        )).fetchone()
+        self.assertEqual(token, '12345')
+        self.assertEqual(step, 'some_step')
+        self.assertEqual(data, 'whatever data')
+
+        token, step, data = config.db.store.execute(
+                old_state_table.select().where(
+                        old_state_table.c.token == '6789'
+                        )).fetchone()
+        self.assertEqual(token, '6789')
+        self.assertEqual(step, 'only_step')
+        self.assertEqual(data, 'other data')
+
+        token, step, data = config.db.store.execute(
+                old_state_table.select().where(
+                        old_state_table.c.token == 'abcde'
+                        )).fetchone()
+        self.assertEqual(token, 'abcde')
+        self.assertEqual(step, None)
+        self.assertEqual(data, 'another data')
+
+    def test_ccb9e28c44f4_mailinglist_sub_unsub_policies_downgrade(self):
+        # Downgrade to the tested revision.
+        alembic.command.downgrade(alembic_cfg, 'ccb9e28c44f4')
+        # Create our example list.
+        with transaction():
+            mlist = create_list('test@example.com')
+            mlist.subscription_policy = ModerationSubscriptionPolicy
+            mlist.unsubscription_policy = OpenUnsubscriptionPolicy
+        # Downgrade, should keep the policies, since they have a value in the
+        # SubscriptionPolicy enum.
+        alembic.command.downgrade(alembic_cfg, '7c5b39d1ecc4')
+        old_mlist_table = sa.sql.table(
+                'mailinglist',
+                sa.sql.column('id', sa.Integer),
+                sa.sql.column('subscription_policy', sa.Integer),
+                sa.sql.column('unsubscription_policy', sa.Integer)
+                )
+        table_id, sub_policy, unsub_policy = config.db.store.execute(
+                old_mlist_table.select()).fetchone()
+        self.assertEqual(sub_policy, SubscriptionPolicy.moderate.value)
+        self.assertEqual(unsub_policy, SubscriptionPolicy.open.value)
+
+    def test_ccb9e28c44f4_mailinglist_sub_unsub_policies_upgrade(self):
+        old_mlist_table = sa.sql.table(
+                'mailinglist',
+                sa.sql.column('id', sa.Integer),
+                sa.sql.column('subscription_policy', sa.Integer),
+                sa.sql.column('unsubscription_policy', sa.Integer)
+                )
+        with transaction():
+            # Downgrade to a revision below the one tested.
+            alembic.command.downgrade(alembic_cfg, '7c5b39d1ecc4')
+
+            config.db.store.execute(
+                    old_mlist_table.insert().values(
+                        subscription_policy=SubscriptionPolicy.moderate.value,
+                        unsubscription_policy=SubscriptionPolicy.open.value)
+                    )
+        # Upgrade and test that the new names and types are there.
+        alembic.command.upgrade(alembic_cfg, 'ccb9e28c44f4')
+        new_mlist_table = sa.sql.table(
+                'mailinglist',
+                sa.sql.column('id', sa.Integer),
+                sa.sql.column('subscription_policy', SAUnicode),
+                sa.sql.column('unsubscription_policy', SAUnicode)
+                )
+        table_id, sub_policy, unsub_policy = config.db.store.execute(
+                new_mlist_table.select()).fetchone()
+        self.assertEqual(sub_policy, ModerationSubscriptionPolicy.name)
+        self.assertEqual(unsub_policy, OpenUnsubscriptionPolicy.name)