summaryrefslogtreecommitdiff
path: root/src/common.c
diff options
context:
space:
mode:
authorbwarsaw2000-08-02 03:22:37 +0000
committerbwarsaw2000-08-02 03:22:37 +0000
commit6ca1d5ded0e9819957bfa34de98fe63d2857930e (patch)
tree711a7dc7e8d79508c3bd7f06642fce3fa9f4db3a /src/common.c
parent8b640b6045de24bdb7e84fc6edbb444e12233c66 (diff)
downloadmailman-6ca1d5ded0e9819957bfa34de98fe63d2857930e.tar.gz
mailman-6ca1d5ded0e9819957bfa34de98fe63d2857930e.tar.zst
mailman-6ca1d5ded0e9819957bfa34de98fe63d2857930e.zip
fatal(): Close SF bug #110401 and potential local security hole by
formatting user supplied input. Also added newlines to both stderr and syslog output for more consistent formatting. Reported by Stan Bubrouski.
Diffstat (limited to 'src/common.c')
-rw-r--r--src/common.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/common.c b/src/common.c
index 11cef7b69..734171b71 100644
--- a/src/common.c
+++ b/src/common.c
@@ -78,7 +78,7 @@ fatal(const char* ident, int exitcode, char* format, ...)
* should definitely know about any problems.
*/
openlog(ident, LOG_CONS, LOG_MAIL);
- syslog(LOG_ERR, "%s", log_entry);
+ syslog(LOG_ERR, "%s\n", log_entry);
closelog();
#endif /* HAVE_SYSLOG */
@@ -108,7 +108,7 @@ fatal(const char* ident, int exitcode, char* format, ...)
printf("</pre>\n");
}
else
- fprintf(stderr, log_entry);
+ fprintf(stderr, "%s\n", log_entry);
#endif /* HELPFUL */
exit(exitcode);
}