Much progress, though not perfect, on migrating to SQLAlchemy 0.4 and Elixir

0.4.  Lots of things changes, which broke lots of our code.  There are still a
couple of failures in the test suite that I don't understand.  It seems that
for pending.txt and requests.txt, sometimes strings come back from the
database as 8-bit strings and other times as unicodes.  It's impossible to
make these tests work both separately and together.

users.txt is also failing intermittently.  Lots of different behavior between
running the full test suite all together and running individual tests.  Sigh.

Note also that actually, Elixir 0.4.0 doesn't work for us.  There's a bug in
that version that prevented zope.interfaces and Elixir working together.  Get
the latest 0.4.0 from source to fix this.

Other changes include:

- Remove Mailman/lockfile.py.  While I haven't totally eliminated locking, I
  have released the lockfile as a separate Python package called locknix,
  which Mailman 3.0 now depends on.

- Renamed Mailman/interfaces/messagestore.py and added an IMessage interface.

- bin/testall raises turns on SQLALCHEMY_ECHO when the verbosity is above 3
  (that's three -v's because the default verbosity is 1).

- add_domain() in config files now allows url_host to be optional.  If not
  given, it defaults to email_host.

- Added a non-public interface IDatabase._reset() used by the test suite to
  zap the database between doctests.  Added an implementation in the model
  which just runs through all rows in all entities, deleting them.

- [I]Pending renamed to [I]Pended

- Don't allow Pendings.add() to infloop.

- In the model's User impelementations, we don't need to append or remove the
  address when linking and unlinking.  By setting the address.user attribute,
  SQLAlchemy appears to do the right thing, though I'm not 100% sure of that
  (see the above mentioned failures).

1 files changed, 23 insertions, 8 deletions

diff --git a/Mailman/database/usermanager.py b/Mailman/database/usermanager.py
index 1958080fd..6bc2ed53d 100644
--- a/Mailman/database/usermanager.py
+++ b/Mailman/database/usermanager.py
@@ -36,7 +36,7 @@ class UserManager(object):
 
     def create_user(self, address=None, real_name=None):
         user = User()
-        user.real_name = (real_name if real_name is not None else '')
+        user.real_name = ('' if real_name is None else real_name)
         if address:
             addrobj = Address(address, user.real_name)
             addrobj.preferences = Preferences()
@@ -49,19 +49,28 @@ class UserManager(object):
 
     @property
     def users(self):
-        for user in User.select():
+        for user in User.query.filter_by().all():
             yield user
 
     def get_user(self, address):
-        found = Address.get_by(address=address.lower())
-        return found and found.user
+        addresses = Address.query.filter_by(address=address.lower())
+        if addresses.count() == 0:
+            return None
+        elif addresses.count() == 1:
+            return addresses[0].user
+        else:
+            raise AssertionError('Unexpected query count')
 
     def create_address(self, address, real_name=None):
-        found = Address.get_by(address=address.lower())
-        if found:
+        addresses = Address.query.filter_by(address=address.lower())
+        if addresses.count() == 1:
+            found = addresses[0]
             raise Errors.ExistingAddressError(found.original_address)
+        assert addresses.count() == 0, 'Unexpected results'
         if real_name is None:
             real_name = ''
+        # It's okay not to lower case the 'address' argument because the
+        # constructor will do the right thing.
         address = Address(address, real_name)
         address.preferences = Preferences()
         return address
@@ -74,9 +83,15 @@ class UserManager(object):
         address.delete()
 
     def get_address(self, address):
-        return Address.get_by(address=address.lower())
+        addresses = Address.query.filter_by(address=address.lower())
+        if addresses.count() == 0:
+            return None
+        elif addresses.count() == 1:
+            return addresses[0]
+        else:
+            raise AssertionError('Unexpected query count')
 
     @property
     def addresses(self):
-        for address in Address.select():
+        for address in Address.query.filter_by().all():
             yield address