Fix connection errors when replacing node

- Avoid connecting the signals to nonexistent methods
- Preserve only persistent connections

(cherry picked from commit d210ac66ef8bbe056c014ba90fd2a12611b51648)

1 files changed, 5 insertions, 2 deletions

diff --git a/scene/main/node.cpp b/scene/main/node.cpp
index 8f02de4c4..a6f0833aa 100644
--- a/scene/main/node.cpp
+++ b/scene/main/node.cpp
@@ -1795,8 +1795,11 @@ void Node::_replace_connections_target(Node *p_new_target) {
 
 		Connection &c = E->get();
 
-		c.source->disconnect(c.signal, this, c.method);
-		c.source->connect(c.signal, p_new_target, c.method, c.binds, c.flags);
+		if (c.flags & CONNECT_PERSIST) {
+			c.source->disconnect(c.signal, this, c.method);
+			ERR_CONTINUE(!p_new_target->has_method(c.method));
+			c.source->connect(c.signal, p_new_target, c.method, c.binds, c.flags);
+		}
 	}
 }