diff options
| author | Rémi Verschelde | 2018-06-22 09:30:17 +0200 |
|---|---|---|
| committer | Rémi Verschelde | 2018-06-22 09:30:17 +0200 |
| commit | 909eaede4c4bb33e2d2e1790709494df02f23a45 (patch) | |
| tree | 97849b51bf72b07649769a80207125781940070f | |
| parent | 4d7aa0b7621f5f128bb31c3319ca8401861a40cc (diff) | |
| download | godot-909eaede4c4bb33e2d2e1790709494df02f23a45.tar.gz godot-909eaede4c4bb33e2d2e1790709494df02f23a45.tar.zst godot-909eaede4c4bb33e2d2e1790709494df02f23a45.zip | |
Disable threading in Asset Library
Threaded HTTPRequest appears to be crashy on 3.0.x.
Fixes #19336.
Diffstat (limited to '')
| -rw-r--r-- | editor/plugins/asset_library_editor_plugin.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/editor/plugins/asset_library_editor_plugin.cpp b/editor/plugins/asset_library_editor_plugin.cpp index dc4c08760..55f870121 100644 --- a/editor/plugins/asset_library_editor_plugin.cpp +++ b/editor/plugins/asset_library_editor_plugin.cpp @@ -515,7 +515,8 @@ EditorAssetLibraryItemDownload::EditorAssetLibraryItemDownload() { download = memnew(HTTPRequest); add_child(download); download->connect("request_completed", this, "_http_download_completed"); - download->set_use_threads(EDITOR_DEF("asset_library/use_threads", true)); + // Threaded HTTPRequest causes crashes (GH-19336) + download->set_use_threads(false); download_error = memnew(AcceptDialog); add_child(download_error); @@ -834,7 +835,8 @@ void EditorAssetLibrary::_request_image(ObjectID p_for, String p_image_url, Imag iq.image_index = p_image_index; iq.image_type = p_type; iq.request = memnew(HTTPRequest); - iq.request->set_use_threads(EDITOR_DEF("asset_library/use_threads", true)); + // Threaded HTTPRequest causes crashes (GH-19336) + iq.request->set_use_threads(false); iq.target = p_for; iq.queue_id = ++last_queue_id; |