From e471cebb4ff0bcee26340fefeb00fb8c83e4a707 Mon Sep 17 00:00:00 2001
From: J08nY
Date: Mon, 27 Oct 2025 19:57:33 +0100
Subject: Fix make_probs estimate.

---
 analysis/scalarmults/epare/simulate.py              |  8 ++++----
 analysis/scalarmults/epare/standalone/make_probs.py | 16 +++++++++++-----
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/analysis/scalarmults/epare/simulate.py b/analysis/scalarmults/epare/simulate.py
index 53c31c3..89d1efc 100644
--- a/analysis/scalarmults/epare/simulate.py
+++ b/analysis/scalarmults/epare/simulate.py
@@ -79,7 +79,7 @@ def evaluate_multiples(
     divisors: set[int],
     use_init: bool = True,
     use_multiply: bool = True,
-):
+) -> ProbMap:
     """
     Takes a Config and MultResults and a set of divisors (base point orders `q`) and
     evaluates them using the error model from the Config. Note that the Config
@@ -122,7 +122,7 @@ def evaluate_multiples_direct(
     divisors: set[int],
     use_init: bool = True,
     use_multiply: bool = True,
-):
+) -> ProbMap:
     """
     Like `evaluate_multiples`, but instead reads the MultResults from a file named `fname`
     at an `offset`. Still returns the ProbMap, which is significantly smaller and easier
@@ -141,7 +141,7 @@ def evaluate_multiples_compressed(
     divisors: set[int],
     use_init: bool = True,
     use_multiply: bool = True,
-):
+) -> ProbMap:
     """
     Like `evaluate_multiples`, but instead reads the MultResults from a file named `fname`
     at an `offset` that is a zstd compressed file.
@@ -161,7 +161,7 @@ def evaluate_multiples_all(
     divisors: set[int],
     use_init: bool = True,
     use_multiply: bool = True,
-):
+) -> list[tuple[Config, ProbMap]]:
     """Like `evaluate_multiples_compressed`, but evaluates all error models."""
     with zstd.open(fname, "rb") as f:
         f.seek(offset)
diff --git a/analysis/scalarmults/epare/standalone/make_probs.py b/analysis/scalarmults/epare/standalone/make_probs.py
index 4d12769..deacff3 100644
--- a/analysis/scalarmults/epare/standalone/make_probs.py
+++ b/analysis/scalarmults/epare/standalone/make_probs.py
@@ -17,8 +17,10 @@ from tqdm import tqdm
 from pyecsca.misc.utils import TaskExecutor
 from ..simulate import evaluate_multiples_all
 from ..divisors import divisor_map
+from ..mult_results import MultResults
 from ..error_model import all_error_models
-from ..config import all_configs
+from ..config import all_configs, Config
+from ..prob_map import ProbMap
 
 if sys.version_info >= (3, 14):
     from compression import zstd
@@ -53,7 +55,7 @@ def main(temp, workers, seed):
         zstd.open(out_path, "wb") as h,
         TaskExecutor(max_workers=workers) as pool,
         tqdm(
-            total=len(all_configs) * len(all_error_models),
+            total=len(all_configs),
             desc=f"Generating probability maps.",
             smoothing=0,
         ) as bar,
@@ -61,7 +63,10 @@ def main(temp, workers, seed):
         file_map = {}
         while True:
             try:
+                mult: Config
+                vals: MultResults
                 mult, vals = pickle.load(f)
+
                 # Store the mult and vals into a temporary compressed file.
                 file = temp / f"v{hash(mult)}.zpickle"
                 file_map[mult] = file
@@ -79,14 +84,15 @@ def main(temp, workers, seed):
                     use_init,
                     use_multiply,
                 )
-                gc.collect()
+
+                # Process any results already done.
                 for mult, future in pool.as_completed(wait=False):
                     bar.update(1)
                     file_map[mult].unlink()
                     if error := future.exception():
                         click.echo(f"Error! {mult} {error}")
                         continue
-                    res = future.result()
+                    res: list[tuple[Config, ProbMap]] = future.result()
                     for full, probmap in res:
                         pickle.dump((full, probmap), h)
             except EOFError:
@@ -101,7 +107,7 @@ def main(temp, workers, seed):
                 click.echo(f"Error! {mult} {error}")
                 continue
             res = future.result()
-            for full, probmap in res.items():
+            for full, probmap in res:
                 pickle.dump((full, probmap), h)
 
 
-- 
cgit v1.2.3-70-g09d2